feat(licensing): quota enforcement, client rejection and trial license limits#71
Merged
Conversation
Before this commit, the quota retrieval and distribution of exceeded IDs would be disabled on mgmtd startup if the feature wasn't licensed. This lead to a couple of issues with enforcement consistency: * When a license expired while mgmtd was running, enforcement would continue to work but only until mgmtd restarts * When mgmtd restarted, collection and distribution of exceeded quotas would be disabled, leading to other nodes enforcing based on an old state * When other nodes restarted, they would still be able to initially fetch outdated quota states and enforce based on them. This commit fixes all of the above by not allowing intial downloads of quota state if the feature is not licensed and not entirely disabling the quota distribution mechanism. If the quota feature is not licensed nodes quota collection from the nodes will be disabled for efficiency reasons, but nodes will still receive exceeded quota updates to allow for online changes in license state. These updates will not contain any information about exceeded IDs and will simply clear out the state on the nodes so quotas will no longer be enforced.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rustybee42
requested changes
May 20, 2026
rustybee42
reviewed
May 20, 2026
Drop the somewhat misleading "Internal" prefix for errors during license verification. These errors are usually caused by invalid or non-existing license files, which isn't an "internal" problem and requires user action.
rustybee42
reviewed
May 26, 2026
rustybee42
left a comment
rustybee42
left a comment
Collaborator
There was a problem hiding this comment.
Found another couple of tiny and a slightly bigger structural issue
philippfalk
force-pushed
the
falk/license-enforcement
branch
from
b1b097c to
fd9f05e
Compare
iamjoemccormick
requested changes
May 28, 2026
Member
There was a problem hiding this comment.
Since Patrick performed the human review, I mostly focused on ensuring this matched my expectations for how licensing would work, testing, and using Claude to analyze the changes.
I had Claude jointly review the changes in this PR and https://github.com/ThinkParQ/beegfs-core/pull/4671/, and I've organized the findings into comments on the respective PRs. I mention this only to note Claude had the full context from the overall change.
rustybee42
requested changes
Jun 1, 2026
rustybee42
left a comment
rustybee42
left a comment
Collaborator
There was a problem hiding this comment.
There is some not so ideal code (unnecessary clone(), unwrap()) that should be fixed, after that it should be good to go.
rustybee42
approved these changes
Jun 1, 2026
rustybee42
left a comment
rustybee42
left a comment
Collaborator
There was a problem hiding this comment.
Looks good now! Don't forget squashing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does three separate things related to licensing:
Tagging @iamjoemccormick for reviewing licensing related semantics and @rustybee42 for reviewing the code flow related changes around quotas and licensing.