fix: guard milestone dispute status transitions - #734
Merged
gboigwe merged 1 commit intoJul 27, 2026
Merged
Conversation
|
@maixuancanh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PendingorInProgressTesting
cargo test -p pulsar-milestone-tracker(20 passed)cargo fmt -p pulsar-milestone-tracker -- --checkcargo clippy -p pulsar-milestone-tracker --all-targetscargo build -p pulsar-milestone-tracker --release --target wasm32-unknown-unknowncargo build --workspaceCI context
The two failing repository-wide checks are also failing on
mainin run 30295342591:ed25519-dalek3.0.0 forsoroban-env-host22.1.3 and fails on their incompatibleCryptoRngtraits before compiling workspace tests.With
ed25519-dalekresolved to 2.2.0 locally,cargo test --workspaceproceeds past that dependency and reaches separate pre-existing compile errors incontracts/publisher-verification/src/test.rs. The focused milestone-tracker suite passes in full.Closes #710