StyleMiiU and some UI improvements - #16
Merged
Merged
Conversation
added 21 commits
July 13, 2026 19:30
- StyleMiiU handling moved to its own module, PluginManager. - Theme install is now responsible for launching worker thread; callbacks are always called on the main thread, from ThemeManager::process(). - Zip file handlign is done now with the Zip module, using RAII to remove explicit error handling.
- Refactored utils functions into ThemeManager. - Filename sanitization replaces all discarded characters by "_", not just the ASCII ones.
…ng to a theme search. - Themezer screen: fixed layout sizing.
- Removed some duplicated code.
- Reorganized SettingsScreen code.
- Fixed a crash when refreshing themes/uthemes while rendering. - Added UI::Title() to unify all "title" rendering in popup windows. - Added UI::ButtonHBox class to create horizontal button boxes. - Moved all confirmation buttons to the right. - Some code reorganization.
- Added debug macros to inject error states, to make testing the error popups easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General:
Themezer screen:
Settings screen:
Manage themes screen:
Internal code changes
Installermodule becameThemeManagerandPluginManager. Some functions fromutilswere moved toThemeManager. Both theme and utheme lists are cached inside the module, so UI code doesn't need to be launching threads anymore.Filename sanitization now replaces all discarded characters by
_; before, all non-ASCII characters were just being deleted.