fix: match isSelfSender on MRI suffix, not exact equality - #15
Merged
Conversation
message.From is sometimes the bare MRI (8:orgid:<guid>) and sometimes a full contact URL ending in it (https://.../users/ME/contacts/8:orgid:<guid>), confirmed against live message data. isSelfSender's exact-equality check never matched the URL form, so the self-author backfill added in #14 silently never fired for messages sent via Send() in a real 1:1 conversation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
message.Fromis sometimes the bare MRI (8:orgid:<guid>) and sometimes a full contact URL ending in it (https://.../users/ME/contacts/8:orgid:<guid>), confirmed against live message data.isSelfSender's exact-equality check never matched the URL form, so the self-author backfill added in #14 silently never fired for messages sent viaSend()in a real 1:1 conversation.Fix: match on suffix instead of exact equality, in both the direct-MRI and ObjectID-derived branches. Backward compatible with the existing bare-MRI test cases; adds a regression test using the real URL shape.
Follow-up to #14.