Improved output - #20
Conversation
|
Output with Full Output |
|
@PhrozenByte Take a look here |
|
additional possible values to provide:
unsure:
|
|
|
I like that, great work ❤️ A few suggestions: How about adding two helper functions to parse times and sizes? For example, instead of printing the write power on hours in both seconds and hours, the script could print them solely in the most reasonable scale. In your example it should be hours, but for the 437 days we had in #14 it should be months. A common method is allowing for up to three times the next scale, i.e. up to 180 minutes, then up to 72 hours, then up to 90 days, then up to 36 months, lastly years, and always rounding up to the next integer and adding a "<" prefix (this way you don't even need float arithmetic). Same with MB, GB, and TB (up to 3000 MB, up to 3000 GB, lastly TB). Another helper could add thousands separators to large numbers. I don't think the exact values really matter, and if one really needs them, one can always use WDYT about hiding the diff if it's 0 or 1, and adding an info text? This kinda conveys that 10 hours is some "fixed" boundary at which one must assume fraud, but it's actually an arbitrary value (it is, right?). I'd rather just always print the info text, telling that "big differences" (i.e. not settle on a definitive boundary) might be an indicator. IMHO this is a little confusing. I'd again remove both the difference and the rather arbitrary treshold, but add a info text instead explaining that - again - "big differences" between the heads possibly indicate fraud or tampering. I like to suggest handling this similar to power on hours, i.e. showing both SMART and FARM values, and also adding a little info text that differences between power cycles and start/stops could be a result of enabled power savings mode, but also of fraud. For consumer HDDs the values will usually wildly differ due to aggressive power saving being enabled by default, but it's a whole different story for enterprise HDDs. Is the output always inverted now? Because, if it's always inverted, I'd say that it should be dealt with in smartmontools instead. However, I always thought that it's just some drives that show it inverted... But I might be wrong. Personally I'm no big fan of normalized values: They are normalized for a full disk lifetime, but I'd expect that most people use your scripts to check new drives. |
No description provided.