docs(cf11g): restore ecosystem context graph prerequisite - #20
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis change reconciles the roadmap identifiers and adds the CF-11G specification package. It defines the Context Graph contract, lock schema v2, deterministic offline processing, CLI behavior, implementation tasks, validation gates, and sequencing before CF-12. ChangesCF-11G Ecosystem Context Graph
Estimated code review effort: 3 (Moderate) | ~20 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Owner
Author
|
@coderabbitai review |
|
Owner
Author
External source review — CF-11G / CF-12 relevanceReviewed the newly supplied sources as design evidence only. No donor code is admitted by this note. Accepted immediate design influence
Accepted future hardening influence, not CF-11G scope
Not relevant to the current roadmap
Resulting CF-11G/CF-12 constraints
This review does not change CF-06 semantics, HL7 pins, the frozen CF-10 corpus, or the existing CF-11G -> CF-12 dependency order. |
Owner
Author
|
@coderabbitai review |
Action performedReview triggered.
|
TheHalfMoon
marked this pull request as ready for review
August 26, 2026 03:48
|
ⓘ Your Qodo trial ends soon. Ask your workspace admin to set up billing to keep reviews running after the trial. Manage billing |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
PR Summary by QodoRestore CF-11G Context Graph prerequisite for commandf impact
AI Description
Diagram
High-Level Assessment
Files changed (5)
|
Code Review by Qodo
1. Source URLs break determinism
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
|
|
||
| ### J. Determinism | ||
|
|
||
| Equivalent resolver root-order permutations and repeated `context` builds over identical bytes MUST produce byte-identical lock v2 and Context Graph JSON respectively. |
There was a problem hiding this comment.
1. Source urls break determinism 🐞 Bug ≡ Correctness
The new acceptance criterion requires byte-identical lock-v2 output for equivalent resolver permutations, but the resolver serializes the actual acquisition URL in LockedPackage.source, which can differ when identical bytes come from the primary endpoint versus the secondary redirect/fallback. Because the plan also requires preserving source provenance without defining a canonical source identity or semantic comparison, the mandated byte-equality proof remains flaky.
Agent Prompt
## Issue description
Lock-v2 byte determinism cannot be guaranteed while `LockedPackage.source` stores a transport-specific URL that may vary across equivalent acquisitions.
## Issue Context
The planning contract must either require a canonical stable source identifier in serialized locks or define determinism evidence as a semantic comparison that normalizes/excludes transport URLs while retaining provenance appropriately.
## Fix Focus Areas
- specs/012-cf-11g-ecosystem-context-graph/spec.md[196-198]
- specs/012-cf-11g-ecosystem-context-graph/plan.md[208-217]
- specs/012-cf-11g-ecosystem-context-graph/tasks.md[39-45]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+124
to
+126
| Canonical execution used `CF-11` for the multi-version package-graph foundation correction required to represent real transitive FHIR package closures. That completed history is retained exactly and is not renamed. | ||
|
|
||
| The ecosystem Context Graph originally planned under numeric CF-11 still remains a required prerequisite for `CF-12 commandf impact`. To restore that missing product capability without rewriting history or shifting every downstream identifier, the graph-gap restoration slice is named: |
There was a problem hiding this comment.
2. Sibling roadmap remains stale 🐞 Bug ⚙ Maintainability
The reconciliation reassigns CF-11 to the multi-version foundation and creates CF-11G for the Context Graph, but COMMAND_F_DISCOVERY_COVERAGE_2026-08-13.md still says its execution stack is unchanged and lists CF-11 as the Context Graph immediately before CF-12. This leaves the authoritative plan set with conflicting slice identities and sequencing despite consistency.md declaring the roadmap contradiction closed.
Agent Prompt
## Issue description
The new CF-11/CF-11G identity mapping conflicts with the retained execution list in the discovery-coverage authority.
## Issue Context
Update the sibling roadmap to preserve historical CF-11 while inserting CF-11G before CF-12, or explicitly replace its numbered list with a pointer to the canonical Master Architecture stack.
## Fix Focus Areas
- docs/COMMAND_F_MASTER_ARCHITECTURE_V2.md[122-134]
- docs/COMMAND_F_DISCOVERY_COVERAGE_2026-08-13.md[642-663]
- specs/012-cf-11g-ecosystem-context-graph/consistency.md[18-43]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconcile the canonical commandF roadmap after historical CF-11 was used for the multi-version package-graph foundation correction.
This PR preserves completed CF-11 history and introduces
CF-11Gas the missing ecosystem Context Graph slice required beforeCF-12 commandf impact.Decision
Spec Kit sequence
012is the next available planning-package number only; it does not renumber downstream product slices.Scope
Documentation / planning only:
docs/COMMAND_F_MASTER_ARCHITECTURE_V2.md;specs/012-cf-11g-ecosystem-context-graph/spec.md;plan.md;tasks.md;Key implementation contract planned
CF-11G will ship:
The plan requires:
resolved/external/ambiguouscanonical target states;Roadmap independence
The external HL7 maintainer/upstream path is not a dependency of this planning or implementation slice. CF-06 production semantics remain unchanged.
Verification boundary
This PR contains no Rust, Cargo, fixture, workflow, lockfile, or runtime behavior changes.
Implementation starts only from the Spec/Plan/Tasks contract after exact-head planning review and will follow the task order in stacked independently reviewable PRs.
Closes #19 when this roadmap/spec reconciliation becomes canonical.
Summary by cubic
Restores the missing Context Graph prerequisite by introducing CF-11G and updating the Master Architecture so CF-12
commandf impactdepends on it. Historical CF-11 remains the multi-version package-graph foundation; this PR is planning-only and changes no runtime behavior.docs/COMMAND_F_MASTER_ARCHITECTURE_V2.mdto addCF-11Gand adjust downstream dependencies (CF-12, CF-16).specs/012-cf-11g-ecosystem-context-graph/{spec.md,plan.md,tasks.md,consistency.md}.commandf contextJSON output and a lock schema v2 requirement with backward read-compatibility for schema v1.resolved/external/ambiguoustarget states.Written for commit 190945b. Summary will update on new commits.
Summary by CodeRabbit
commandf contextcommand, supported FHIR canonical-reference extraction, cache verification, bounded inputs, and fail-closed behavior for incomplete lock data.