feat(corpus): establish public real-IG delta benchmark - #11
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Merge canonical CF-11 foundation into the frozen CF-10 branch without changing CF-10 corpus files, preserving branch history before the same-six-state eligibility rerun.
|
@codex review Please review the current implementation head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c03b2366c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
900f938 to
5fe10d9
Compare
TheHalfMoon
left a comment
There was a problem hiding this comment.
CF-10 patched-HL7 full frozen-corpus qualification is proven and deterministic. Upstream gate remains external: hapifhir/org.hl7.fhir.core PR #2554 is OPEN / NON-DRAFT / MERGEABLE at head e67d1c3f1d984fde11b2dfeb522bf9cba8c8d066 against unchanged master b06c7ee7c57367305ff72b6bb09ce779b5dbd6ce, with no maintainer reviews/comments yet. Upstream branch protection requires Pull Request Pipeline; the currently visible fork-triggered GitHub workflows are action_required, so no CI failure is inferred. A reviewer request to listed maintainer grahamegrieve was attempted through the GitHub integration and rejected with 403 Resource not accessible by integration; no upstream mutation occurred. Production CF-06 pin remains unchanged; PR #11 remains Draft/unmerged; CF-12 remains not started.
Decision state
CF-10 implementation, review debt, and the patched-HL7 full frozen-corpus qualification are proven on retained evidence. CF-10 remains blocked only by the current CF-06 production oracle contract: production is still pinned to the unpatched official HL7 6.10.2 source.
The frozen three-case corpus remains unchanged. No case has been replaced based on semantic results. CF-03 remains commandF semantic authority; the HL7 comparator remains an independent advisory oracle.
Narrow proven classification:
This does not authorize a production oracle pin change, semantic reinterpretation, PR merge, or CF-12.
Exact current identity
Frozen corpus — UNCHANGED
Foundation status
CF-11 corrected the package graph so the resolver can retain multiple concrete versions of the same package name in distinct transitive branches while preserving exact
(name, version, digest)identity and fail-closed downstream ambiguity behavior.Canonical foundation main:
All six frozen package states are representable and attested.
Current production-pin truth
With the unchanged production CF-06 pin, the corpus executes through all commandF-owned semantic stages but C001/C002 fail operationally inside the pinned HL7 comparator:
Observed pinned-oracle failures:
Under the current CF-06 contract these remain operational failures. They are not converted to
agreement,uncomparable, or semantic success.Deterministic root-cause qualification
Pinned-source qualification:
Independent qualification result files were byte-identical:
Root-cause classification:
Exact failing resources:
For both cases,
self_before,self_after, andcrossfail identically under direct dependency context and deterministic full-closure context. The comparator therefore fails even on self-comparison of valid published profiles; commandF package context is not the root cause.Upstream HL7 fixes
Two independent
DefinitionNavigatordefects were isolated and fixed narrowly:contentReferencetraversal — same-path named slices of the referenced master are siblings, not children of the referencing element.Targeted qualification against exact 6.10.2 source:
Upstream submission:
The upstream regression tests pass with the fix and fail with the exact production exceptions when the source fix is removed.
Full patched frozen-corpus qualification — PROVEN
Qualification-only commandF branch:
Full proof:
Every substantive workflow step completed successfully, including both independent complete executions of the unchanged frozen CF-10 corpus, evidence upload, and final enforcement.
Evidence artifact:
Deterministic A/B proof:
Per-case patched result:
Per-case oracle report SHA-256:
This proves that the two isolated upstream fixes are sufficient for the entire unchanged frozen CF-10 corpus under the patched exact 6.10.2-source experiment. It does not make the patched fork/source the production CF-06 oracle identity.
Full-closure evidence binding — P1 CLOSED
Fix commit:
Fresh live full-corpus reproof:
Closure verifier tests, clean A/B runs, deterministic summary comparison, retained lock/summary closure binding, repository boundary, and evidence upload all passed. Final enforcement failed only because of the separately qualified production-pin C001/C002 HL7 operational failures. The P1 thread is answered and resolved.
Partial-report persistence — P2 CLOSED
Retained artifact evidence from run
31916124080proves that in both A and B, C001 and C002 retainstructural.json,compatibility.json, andterminology.jsonalongside lateroracle-failure.txt. C003 retains all four successful reports.The P2 thread is answered and resolved.
Pinned HL7 oracle identity — UNCHANGED
Current production CF-06 contract remains:
GitHub
releases/lateststill reports 6.10.2 as the latest official release as of 2026-08-16. There is no newer official release that can simply replace the current pin.CF-06 next-gate tracking
Now that the patched full-corpus proof is green, the required sequence remains:
Runtime/performance hardening is tracked separately in commandF #16 and must not weaken CF-06 determinism or fail-closed behavior.
Current governance
Next gate
The blocker has moved from technical uncertainty to upstream/contract governance:
PR #11 remains Draft and unmerged until that governance path is resolved or the founder explicitly chooses another CF-06 contract path.