Skip to content

docs(winds): close T056 local history privacy - #36

Merged
TheHalfMoon merged 2 commits into
mainfrom
docs/003-t056-closeout
Aug 17, 2026
Merged

docs(winds): close T056 local history privacy#36
TheHalfMoon merged 2 commits into
mainfrom
docs/003-t056-closeout

Conversation

@TheHalfMoon

@TheHalfMoon TheHalfMoon commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Spec 003 / T056 closeout

Record canonical completion evidence for T056 after implementation PR #35 merged and post-merge platform gates passed.

Canonical implementation evidence

  • implementation PR: feat(winds): add bounded local history and secret-safe metadata #35
  • final exact implementation head: 35141774825701ebe744ce25adf1dab03d17613e
  • quality #344: PASS
  • windows-terminal #121 on official windows-latest: PASS
  • release-candidate #191: PASS
  • SC-001 deterministic 100-cycle soak: PASS
  • Linux x86-64 and macOS arm64 release bundles/artifacts: PASS
  • exact-head correctness/safety/privacy review: PASS
  • exact-head Ponytail v4.9.0 simplicity review: PASS
  • CodeRabbit final incremental exact-head review completed with no new unresolved finding
  • Qodo final Deep review: Bugs (0); the remaining rule-level objection to the numeric 8 MiB ceiling is reconciled as a non-public allocation-safety bound, not a Spec requirement
  • unresolved review threads: 0

Merge and canonical proof

PR #35 was squash-merged with an exact expected-head guard as canonical main:

923ac872a14d75d5362695c4d7b385a0227b2f24

Post-merge canonical checks on that exact main:

  • quality #345: PASS
  • windows-terminal #122: PASS

Accepted T056 boundary

The accepted slice keeps transcript persistence local, bounded, explicit opt-in and default-off; supports per-session command/transcript disable; accounts transcript plus manifest bytes under total quota with explicit truncation/completion metadata; conservatively sanitizes secret-bearing arguments and URL-like launch metadata without claiming perfect secret detection; persists no full environment snapshot; requires matching typed terminal identity; performs recursive cleanup only after strict owned-descendant validation; and releases the primary winds.db writer transaction before history filesystem work.

History artifacts remain workspace/session history only and do not become BlobEvidence, eligibility, promotion input, or winds verify authority.

This PR

Changes only specs/003-workspace-execution-spine/tasks.md. The only semantic change is T056 [ ] -> [x] plus the canonical evidence above; the file also normalizes its final newline. T057 remains [ ] and is not started by this closeout.

No source, migration, dependency, workflow, runtime, CLI, protocol, daemon/server/socket, plugin/provider, MCP/ACP/A2A, Agent Fleet, or verification-authority behavior changes are made here.


Summary by cubic

Marks T056 as complete in Spec 003 and records canonical acceptance evidence. This closes the local history/transcript privacy task without changing product behavior.

  • Changes only specs/003-workspace-execution-spine/tasks.md: switch T056 from unchecked to checked, add canonical evidence, and normalize the final newline.
  • No source, runtime, schema, dependency, workflow, or CLI changes. No migration required.
  • T057 remains unchecked. History artifacts remain workspace/session-only and are not BlobEvidence, eligibility, promotion input, or winds verify authority.

Written for commit 3e5930a. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • New Features
    • Added opt-in, default-off persistence for local session transcripts and history.
    • Added per-session controls, quota and truncation metadata, and coordinated history pruning.
    • Added conservative secret sanitization and terminal identity validation.
    • Added cleanup for owned terminal descendants.
  • Documentation
    • Clarified that persisted history is separate from verification authority.
    • Documented follow-up support for detached live terminal sessions across restarts.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: bed9657d-38cc-4e03-916b-f3894068faf1

📥 Commits

Reviewing files that changed from the base of the PR and between 923ac87 and 3e5930a.

📒 Files selected for processing (1)
  • specs/003-workspace-execution-spine/tasks.md

📝 Walkthrough

Walkthrough

The task specification marks T056 complete with bounded, opt-in local history and transcript persistence details. A follow-on item now covers detached live terminal sessions across Winds restarts.

Changes

Workspace execution persistence

Layer / File(s) Summary
Persistence task record
specs/003-workspace-execution-spine/tasks.md
T056 now records persistence limits, per-session disabling, quota and truncation metadata, secret sanitization, terminal identity validation, cleanup, pruning, evidence, and separation from verification authority. The follow-on item covers detached live terminal sessions across Winds restarts.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • TheHalfMoon/Winds#35: Implements the bounded local history and transcript persistence described by this task update.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/003-t056-closeout

Comment @coderabbitai help to get the list of available commands.

@TheHalfMoon
TheHalfMoon marked this pull request as ready for review August 17, 2026 03:55
@TheHalfMoon
TheHalfMoon merged commit ca4ed9a into main Aug 17, 2026
2 of 3 checks passed
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can route each action level your way: inline, summary, both, or drop

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

docs(winds): close out T056 with canonical completion evidence

📝 Documentation 🕐 Less than 5 minutes

Grey Divider

AI Description

• Mark Spec 003 task T056 as complete in the checklist.
• Record canonical acceptance/merge evidence for PR #35 and post-merge gates.
• Normalize EOF newline in the tasks file.
High-Level Assessment

The approach is optimal for a closeout: keep the canonical evidence inline next to the task checkbox in the spec checklist. Alternatives (e.g., separate release notes or a standalone closeout doc) add indirection without improving reviewability for Spec 003 task tracking.

Files changed (1) +2 / -2

Documentation (1) +2 / -2
tasks.mdMark T056 complete and add canonical acceptance evidence +2/-2

Mark T056 complete and add canonical acceptance evidence

• Changes T056 from unchecked to checked and appends a detailed canonical evidence block referencing PR #35, exact heads, gate runs, and accepted behavioral boundaries. Also normalizes the file to end with a newline.

specs/003-workspace-execution-spine/tasks.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant