fix(circular_buffer): narrow trimStart patch to _absoluteStartIndex a…#225
Open
aswin-auxvera wants to merge 1 commit into
Open
fix(circular_buffer): narrow trimStart patch to _absoluteStartIndex a…#225aswin-auxvera wants to merge 1 commit into
aswin-auxvera wants to merge 1 commit into
Conversation
…dvancement only The original patch's _dropChild loop nulled BufferLine._owner and BufferLine._absoluteIndex on trimmed entries. CellAnchors holding direct references to those entries — whose .y/.offset getters guard _owner!.index access with assert(attached), stripped in release mode — then null-deref'd on the next access from xterm's escape parser (eraseLineFromCursor → currentLine → ... → CellAnchor.y → _absoluteIndex! on null → _TypeError). Symptom: app shows "Unexpected Error: _TypeError" dialog on every shell prompt redraw following any clearScrollback in release builds. Pre-patch behaviour was silent index corruption (rendered off-screen, no crash); the broader patch traded silent for loud. Narrowing to advance _absoluteStartIndex only preserves the original selection-render and copy fixes (those rely on surviving entries' index, which the narrowed patch handles correctly) without exposing the pre-existing CellAnchor release-mode invariant violation. Orphan-anchor cleanup is now a non-goal of trimStart and should be handled by callers (Buffer.clearScrollback, or the host application) at their own layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dvancement only
The original patch's _dropChild loop nulled BufferLine._owner and BufferLine._absoluteIndex on trimmed entries. CellAnchors holding direct references to those entries — whose .y/.offset getters guard _owner!.index access with assert(attached), stripped in release mode — then null-deref'd on the next access from xterm's escape parser (eraseLineFromCursor → currentLine → ... → CellAnchor.y → _absoluteIndex! on null → _TypeError).
Symptom: app shows "Unexpected Error: _TypeError" dialog on every shell prompt redraw following any clearScrollback in release builds. Pre-patch behaviour was silent index corruption (rendered off-screen, no crash); the broader patch traded silent for loud.
Narrowing to advance _absoluteStartIndex only preserves the original selection-render and copy fixes (those rely on surviving entries' index, which the narrowed patch handles correctly) without exposing the pre-existing CellAnchor release-mode invariant violation.
Orphan-anchor cleanup is now a non-goal of trimStart and should be handled by callers (Buffer.clearScrollback, or the host application) at their own layer.