feat(schematics): ng add ui-platform#23
Open
richavyas wants to merge 16 commits into
Open
Conversation
| @@ -0,0 +1,21 @@ | |||
| # Run test and linter | |||
Contributor
There was a problem hiding this comment.
This should not have pre-commit in the name. Also, where is this used?
Contributor
Author
There was a problem hiding this comment.
As the test step says, it's a temp script which is added for testing this entire feature locally. so you just have to run the script for testing it.
Contributor
There was a problem hiding this comment.
Let's remove precommit from the name
christianmemije
suggested changes
Dec 16, 2019
Contributor
christianmemije
left a comment
christianmemije
left a comment
There was a problem hiding this comment.
Tests failing.
Started
.F...
Failures:
1) ng-add schematic should create proxy.conf.js when sso option is selected by user
Message:
Expected false to be true.
Stack:
Error: Expected false to be true.
at Object.<anonymous> (/Users/cm250080/repos/teradata/vantage-ui-platform/src/lib/schematics/ng-add/index.spec.js:37:46)
at Generator.next (<anonymous>)
at fulfilled (/Users/cm250080/repos/teradata/vantage-ui-platform/node_modules/tslib/tslib.js:107:62)
at processTicksAndRejections (internal/process/task_queues.js:86:5)
Message:
Failed: The file (proxy.conf.js) does not exist.
Stack:
Error: The file (proxy.conf.js) does not exist.
at Object.getFileContent (/Users/cm250080/repos/teradata/vantage-ui-platform/node_modules/@schematics/angular/utility/test/get-file-content.js:6:15)
at Object.<anonymous> (/Users/cm250080/repos/teradata/vantage-ui-platform/src/lib/schematics/ng-add/index.spec.js:38:36)
at Generator.next (<anonymous>)
at fulfilled (/Users/cm250080/repos/teradata/vantage-ui-platform/node_modules/tslib/tslib.js:107:62)
at processTicksAndRejections (internal/process/task_queues.js:86:5)
5 specs, 1 failure
Finished in 3.396 seconds
…ta/vantage-ui-platform into feature/schematics-ng-add
owilliams320
suggested changes
Mar 5, 2020
| /* Vantage and local development environments */ | ||
| /* * * * * * * * * * * */ | ||
|
|
||
| const serverUrl = 'https://vantage.url.io'; // REPLACE WITH VANTAGE BASE URL |
Contributor
There was a problem hiding this comment.
can this be interpolated with the ssoServerURL options?
Suggested change
| const serverUrl = 'https://vantage.url.io'; // REPLACE WITH VANTAGE BASE URL | |
| const serverUrl = '<%= ssoServerURL %>'; // VANTAGE BASE URL |
Contributor
There was a problem hiding this comment.
not sure if the quotes would be needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR takes care of adding the capability of ng-add schematics to ui-platform so that user can start adding ui-platform to their project with a single command.
ng add @td-vantage/ui-platformcloses #7
Prerequisites:
Adding covalent is a prerequisite for adding ui-platform. Since covalent schematics is not released yet, incorporating
ng add @covalent/coreas part of ui-platform's ng-add schematics isn't possible atm. This would be a future enhancement.What's included?
ng-add(Proposed command for publishingng add @td-vantage/ui-platform)###Test Steps