refactor(fnos): split fnos packaging into docker/ and native/ variants - #421
Merged
Conversation
The bundled subagent catalog now loads 19 divisions (272 agents), but two tests still hard-coded an expected count of 16. Update the assertions so the pre-commit suite is green.
Restructure the FnOS package layout so the Docker build and the native installer live under separate directories (fnos/docker and fnos/native) instead of a single fnos/ tree plus a parallel fnos-native/. Update the FPK build workflow, build-fpk.sh and fnos/common.sh to source from the new paths, and refresh fnos/README.md accordingly. Follow-up to PR #407.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the original working-tree diff into two focused PRs (this is the FnOS packaging half; the dashboard + backend half is in a separate PR).
Restructure the FnOS package layout so the Docker build and the native installer live under separate directories instead of a single
fnos/tree plus a parallelfnos-native/:fnos/→fnos/docker/(Docker FPK build)fnos-native/→fnos/docker/+fnos/native/(the native installer assets move intofnos/native/)Updated call sites:
.github/workflows/fnos-build-fpk.ymlscripts/build-fpk.shscripts/fnos/common.shfnos/README.mdNotes
fix(tests): align subagent catalog division count with bundled library) is included as the base of this branch to keepdevelopgreen — the same pre-existing test fix carried by the companion dashboard/backend PR.make all+ dashboard build) passes.Test plan
.github/workflows/fnos-build-fpk.yml; verify the workflow resolvesfnos/dockerandfnos/nativeafter merge.bash -n scripts/build-fpk.sh scripts/fnos/common.shfor shell syntax.