feat(onnx): race Hugging Face and hf-mirror for model downloads - #415
Open
liukewia wants to merge 4 commits into
Open
feat(onnx): race Hugging Face and hf-mirror for model downloads#415liukewia wants to merge 4 commits into
liukewia wants to merge 4 commits into
Conversation
…ling - Introduced a new module `onnx_download.py` to handle racing between Hugging Face and hf-mirror for model downloads, improving download efficiency. - Added a helper function `_hf_repo_from_sources` to streamline Hugging Face repository ID extraction from model metadata. - Updated `get_onnx_model_meta` and `list_onnx_catalog_models` to utilize the new helper function for cleaner code and better handling of source metadata. - Added unit tests for the new download functionality and metadata handling to ensure reliability and correctness.
- Introduced a logging mechanism for ONNX model downloads, redirecting progress output to a log file instead of stdout/stderr. - Added a new method `ensure_log` in `PathLayout` to create and return the log file path. - Updated unit tests to verify that download progress messages are correctly logged. - Improved the `_download_hf_snapshot` function to utilize the new logging functionality, enhancing traceability during model downloads.
- Added a new `on_progress` callback to the `download_model_raced` function to report download progress. - Implemented a `_ui_progress_from_bytes` function to calculate the fraction of downloaded bytes for better UI feedback. - Updated the `OnnxDownloadManager` to utilize the new progress tracking during model downloads. - Enhanced unit tests to verify the correct reporting of download progress and ensure that the new functionality works as intended.
- Eliminated the 10-second sleep for URLs starting with the Hugging Face official endpoint, streamlining the probe process. - This change enhances the efficiency of the `probe_source` function by reducing unnecessary wait times during model downloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snapshot_downloadpath in the ONNX download manager.Target branch
develop(feature / fix — default)main(release/*orhotfix/*only)Type of change
Test plan
uv run pytest tests/unit/agents/test_onnx_download.py tests/unit/agents/test_onnx_service.py -q— 28 passedDid not run
make allon this branchmake allpasses locallyAdded/updated tests
Checklist
CHANGELOG.md(if user-facing)Made with Cursor