Fix macOS release build: restore notice imports - #76
Open
lalmei wants to merge 1 commit into
Open
Conversation
The mac() path needs Color, Attribute, and notice, but those imports were gated to Windows only.
lalmei
force-pushed
the
fix/macos-build
branch
from
August 20, 2026 21:52
4cd1827 to
5e64090
Compare
Author
|
@Tekunogosu not sure if your CI runs linux, and windows, was only able to test locally on Mac Os. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo build --releasecurrently fails on macOS becauserustique_options::mac()usesnotice,Color, andAttribute, but those imports were gated with#[cfg(windows)].#[cfg(any(windows, target_os = "macos"))]) so the crate compiles again.cargo build --releaseon macOS.Test plan
cargo build --releasesucceeds on macOS