PHP8.0環境構築キット（Windows10）追加#21
Open
Auron0330 wants to merge 7 commits into
Open
Conversation
yonyon-web
reviewed
Oct 17, 2021
Contributor
Author
There was a problem hiding this comment.
WSL2の構築キットリリース後に追加します。
Contributor
Author
There was a problem hiding this comment.
#17 (comment) と同様の内容で修正いたしました。
1e94a4f にて対応いたしました。
There was a problem hiding this comment.
自分はコマンドの後に実行結果を書くというフォーマットを知っているので理解できるのですが読者はフォーマットをしらないので
「コマンドが完了しても特にメッセージは表示されません。」の方が意図が伝わりやすいかなと思いました。
Contributor
Author
There was a problem hiding this comment.
こちら、同時に20個くらいパッケージをインストールしているので、実行結果の行数がかなり多く、インストールの確認が大変なのでここでは省略しています。
エラー発生の頻度はあまり高くないと思うので、問題ないかと思います。
There was a problem hiding this comment.
なるほど、実行結果省略の件理解しました。
バージョンコマンドやディレクトリがあるかどうかの確認などでそれぞれのパッケージが無事インストールできている確認できればより良いのかなと思いました
Contributor
Author
|
@44x1carbon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.