feat: add structured JSON logging using structlog (closes #19)#47
Merged
Teboho66 merged 2 commits intoJun 8, 2026
Merged
Conversation
Teboho66
self-requested a review
June 8, 2026 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces ad-hoc
print()statements with structured JSON logging usingstructlog, making SentinelPay logs parseable by tools like Grafana Loki and AWS CloudWatch.Changes
Assignment 12/api/logging_config.py(new file)structlogwith ISO timestamps, log levels, exception formatting, and JSON rendering to stdoutget_logger()helper for use across the codebaseAssignment 12/handlers/routes/transactions.pylogger.info("transaction_submitted", ...)on every successful transaction submission, includingtransaction_id,amount, andcurrencylogger.info("fraud_decision_applied", ...)on every fraud decision, includingtransaction_idandfraud_scorelogger.error("unhandled_error", ...)with traceback for all unhandled 500 errorsrequirements.txtstructlogdependencySample Log Output
{"timestamp": "2026-06-08T10:00:00Z", "level": "info", "event": "transaction_submitted", "transaction_id": "txn-abc-123", "amount": 500.0, "currency": "ZAR"} {"timestamp": "2026-06-08T10:00:01Z", "level": "info", "event": "fraud_decision_applied", "transaction_id": "txn-abc-123", "fraud_score": 0.87}Acceptance Criteria Met
Testing
Ran
PYTHONPATH=".:../Assignment 10:../Assignment 11" pytest tests/ -v— all 116 tests pass.Closes #19