Make React icons RSC friendly#4
Conversation
|
@vercel review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR removes the ChangesProvider Removal and Component Refactoring
Test and Documentation Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
@podlink/icons/reactprop-only by removingPodlinkProvider/usePodlinkConfigWhy
The primary consumer is the Podlink Next.js App Router app. The previous React entrypoint pulled context APIs into the public barrel, which made the package easy to import through a server path and could produce confusing production build failures. The icon and badge components do not need package-level context, so this keeps the React API smaller and RSC-friendly.
Validation
pnpm buildpnpm testdist/react/index.jsanddist/react/index.cjscontain nouse client,createContext, oruseContext/Users/nathan/Developer/podlink-v3and ran:pnpm exec tsc --noEmitpnpm exec next buildwith dummy values for required env varsSummary by CodeRabbit