Confusion noise sensitivity curve change - #129
Conversation
…efault in all functions calling the LISA psd. Changed the documentation accordingly.
|
Ah - missed the tests. First time using github on a public project :). I'll have a look at the failed assertion test on the mission observation time. I think the rest is a side effect of the np.trapz deprecation if I understand correctly, didn't change that in this pull request and just downgraded numpy on my side to make sure everything runs as I wasn't sure of commit courtesy w/ several issues. |
|
I believe the test behavior in test_mission_length_effect() to be incorrect. (I don't know whether I can or should modify tests in pull requests however, so I will not resubmit for now - on my end the commit works and gives expected behavior provided numpy is downgraded to avert the trapz issue) |
As suggested in #125, implemented the Karnesis confusion noisein psd.py; changed this to default in all functions calling the LISA psd instead of Robson+19. Changed the documentation accordingly.
Wasn't sure what column of Table II to use (the exact confusion noise depends a bit on the iterative subtraction / smoothing scheme employed), but all give very similar curves.