Fix ArgumentCountError when the audited model is missing - #72
Merged
Conversation
swilla
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
The default audit and restoreAudit gates required a second argument. Laravel Auditing’s auditable relation is morphTo() without
withTrashed(), so $record->auditable is null when the related model has been deleted or soft-deleted. Filament then calledcan('restoreAudit', null)while rendering the audits table, which invoked the gate with only the user and threw:Too few arguments to function … FilamentAuditingServiceProvider::packageBooted() … 1 passed … exactly 2 expected
This matches TappNetwork/filament-auditing#67.
This PR make the resource argument optional on both gates so a missing auditable does not crash. Hide the restore action unless the auditable still exists and the event is updated. This follows Laravel Auditing:
$audit->auditablemay be null by default; apps that need soft-deleted models can opt into a custom Audit model withwithTrashed()viaconfig/audit.phpimplementation. Hard-deleted models remain null either way, and restore still requires a live record.