Skip to content

talos: add searchDomains to clear DHCP search domains - #4850

Draft
Tanguille wants to merge 1 commit into
mainfrom
talos-resolver-search-domains
Draft

talos: add searchDomains to clear DHCP search domains#4850
Tanguille wants to merge 1 commit into
mainfrom
talos-resolver-search-domains

Conversation

@Tanguille

Copy link
Copy Markdown
Owner

Clear DHCP search domains in Talos machine config (card t_990e8fae)

Requires a Talos maintenance window to apply (takes effect at next
talosctl apply / node maintenance) — merge may land ahead of apply.

@github-actions [skip CI]

Verification:

  • git diff shows exactly 2 added lines: and
  • is at 2-space indentation, same as
  • is indented 4 spaces (one level deeper)

CI (Flate) will lint/render template validity.

>
    searchDomains:
      domains: []
+
+ hostDNS:
+   enabled: true
+
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

DeepSource Code Review

We reviewed changes in 34a2838...763a226 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Sep 3, 2026 5:06p.m. Review ↗
Shell Sep 3, 2026 5:06p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant