Skip to content

chore!: Read TANGLE_REVISION variable for Bugsnag #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morgan-wowk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore!: Read TANGLE_REVISION variable for Bugsnag #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cloud_pipelines_backend/instrumentation/bugsnag_instrumentation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
Environment variables:
TANGLE_BUGSNAG_API_KEY Required to enable Bugsnag reporting.
TANGLE_ENV Release stage (e.g. "staging", "production").
TANGLE_SERVICE_VERSION App version tag (e.g. git SHA). Optional.
TANGLE_REVISION App version tag (e.g. git SHA). Optional.
TANGLE_BUGSNAG_NOTIFY_ENDPOINT Custom notify URL. Optional.
TANGLE_BUGSNAG_SESSIONS_ENDPOINT Custom sessions URL. Optional.
TANGLE_BUGSNAG_CUSTOM_GROUPING_KEY Metadata key for normalized error grouping. Optional.
Expand All @@ -28,7 +28,7 @@

_BUGSNAG_API_KEY = os.environ.get("TANGLE_BUGSNAG_API_KEY")
_TANGLE_ENV = os.environ.get("TANGLE_ENV")
_SERVICE_VERSION = os.environ.get("TANGLE_SERVICE_VERSION")
_SERVICE_VERSION = os.environ.get("TANGLE_REVISION")
_NOTIFY_ENDPOINT = os.environ.get("TANGLE_BUGSNAG_NOTIFY_ENDPOINT")
_SESSIONS_ENDPOINT = os.environ.get("TANGLE_BUGSNAG_SESSIONS_ENDPOINT")
_CUSTOM_GROUPING_KEY = os.environ.get("TANGLE_BUGSNAG_CUSTOM_GROUPING_KEY")
Expand Down
2 changes: 1 addition & 1 deletion cloud_pipelines_backend/instrumentation/opentelemetry/_internal/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class EnvVar(str, enum.Enum):
METRIC_EXPORTER_ENDPOINT = "TANGLE_OTEL_METRIC_EXPORTER_ENDPOINT"
METRIC_EXPORTER_PROTOCOL = "TANGLE_OTEL_METRIC_EXPORTER_PROTOCOL"
ENV = "TANGLE_ENV"
SERVICE_VERSION = "TANGLE_SERVICE_VERSION"
SERVICE_VERSION = "TANGLE_REVISION"


class ExporterProtocol(str, enum.Enum):
Expand Down
4 changes: 2 additions & 2 deletions tests/instrumentation/test_bugsnag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def test_setup_noop_when_disabled(monkeypatch):
def test_setup_calls_bugsnag_configure_when_enabled(monkeypatch):
monkeypatch.setenv("TANGLE_BUGSNAG_API_KEY", "test-api-key")
monkeypatch.setenv("TANGLE_ENV", "staging")
monkeypatch.delenv("TANGLE_SERVICE_VERSION", raising=False)
monkeypatch.delenv("TANGLE_REVISION", raising=False)

import importlib
import cloud_pipelines_backend.instrumentation.bugsnag_instrumentation as bugsnag_module
Expand All @@ -88,7 +88,7 @@ def test_setup_calls_bugsnag_configure_when_enabled(monkeypatch):
def test_setup_includes_app_version_when_set(monkeypatch):
monkeypatch.setenv("TANGLE_BUGSNAG_API_KEY", "test-api-key")
monkeypatch.setenv("TANGLE_ENV", "production")
monkeypatch.setenv("TANGLE_SERVICE_VERSION", "abc123")
monkeypatch.setenv("TANGLE_REVISION", "abc123")

import importlib
import cloud_pipelines_backend.instrumentation.bugsnag_instrumentation as bugsnag_module
Expand Down
Loading