Open
Conversation
…persistence Align reference and guides with Provider[] API; spread provideTanStackQuery in snippets, examples, and angular-cli integration.
Document phase-1 adapter work ahead of the stable package rollout.
Align TypeScript and zone.js for the CLI integration, dedupe Angular peers in the devtools-panel example, trim unused devDependencies, extend Knip workspace config, and satisfy ESLint/JSDoc on hydration and persist helpers.
Contributor
|
Important Review skippedToo many files! This PR contains 193 files, which is 43 over the limit of 150. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (193)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
I joined my previous PR's #10340 and #9986, that continued the work of @arnoud-dv at #9893, into 2 step PRs, one for fixing multiple issues, and another one for preparing the non-experimental release.
This one gets upgrades the deps to angular +19, fixes most reported issues, and ads a couple of features that might be expected to work for SSR (like in Analog).
The core idea is that this PR is as backwards compatible as it can be, but it prepares everything for a stable release that removes the usage of deprecated angular APIs (that are not part of LTS) and marks as deprecated some of the exported APIs. It is a heavy PR since it includes some new features for SSR plus examples for it, and a lot of tests to verify correct behavior. The commits are split in a way that is easier to review commit by commit.
Ordering the changes was heavelly powered by AI, but the core internal changes were not made by it.
New things and things to be aware of:
.datakicks off theCreateQueryOptionsfunction #7488. Most of the work here is taking what was started on @arnoud-dv's PR at refactor(angular-query): require Angular v19+ and rely on component effect schedule timing #9893injectQuerieswithHydrationKey()andwithNoQueryHydration(), allowing multiple clients for hydratationa and using the same opt out of hydratation behaviour as the Angular HTTP ClientwithNoHttpTransferCache(). This might match some users expectation of how the client should work in Angular.withPersistQueryClientby allowing a different signature that only runs on the browser.I'm pushing some changes to my own scope
@benjavicente/angular-query-experimental, but I will love to have a more official PR preview channel withpkg-pr-newfor the PR, and then the fixes and features in the official package.The next PR for the stable release would be this one: benjavicente#8
✅ Checklist
pnpm run test:pr.🚀 Release Impact