Various fixes and improvements

[KenVanHoeylandt]

• Optional internal pull-ups for SD/MMC pins in DTS
• Selectable on‑chip LDO channel for SD/MMC power (can be disabled)
• Added several sensor/driver modules to generic ESP32 device configurations so that they become part of the SDKs
• SD card mount now prints card information for clearer diagnostics
• Fix for bug DTS boolean parsing. Improved tests to catch these issues.
• Expanded SDK integration test to include new modules and headers
• Modularized packaging to generate per‑module build files and include driver assets

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Added SDMMC configuration and tooling updates: the sdmmc0 devicetree node gains a pullups property; the ESP32 SDMMC binding adds pullups (bool) and on-chip-ldo-chan (int); Esp32SdmmcConfig now includes pullups and on_chip_ldo_chan. The driver applies internal pull-ups when enabled, conditionally initializes the on‑chip LDO only when on_chip_ldo_chan > 0, and prints card info after a successful mount. Build and packaging scripts (CMake and release tooling) were revised to produce per‑module CMakeLists and adjust prebuilt/component handling; several device YAMLs and tests were updated to reference additional driver modules.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Various fixes and improvements' is vague and generic, failing to describe the specific changes made in this PR focused on LilyGO T-HMI SD card configuration.	Use a more specific title that reflects the main change, such as 'Add SD card pullup support and LDO channel configuration for ESP32 SDMMC' or 'Configure LilyGO T-HMI SD card with pullups and on-chip LDO'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5b3db675-3bd0-49a3-bf99-56f9ae0109b8

📥 Commits

Reviewing files that changed from the base of the PR and between e560cc7 and 36db476.

📒 Files selected for processing (4)

• Devices/lilygo-thmi/lilygo,thmi.dts
• Platforms/platform-esp32/bindings/espressif,esp32-sdmmc.yaml
• Platforms/platform-esp32/include/tactility/drivers/esp32_sdmmc.h
• Platforms/platform-esp32/source/drivers/esp32_sdmmc_fs.cpp

[coderabbitai]

Actionable comments posted: 4

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ce0a974f-e435-45d0-8ce1-eb7f04bb3628

📥 Commits

Reviewing files that changed from the base of the PR and between e7e8c50 and aa954da.

📒 Files selected for processing (6)

• Buildscripts/TactilitySDK/CMakeLists.txt
• Buildscripts/release-sdk.py
• Devices/generic-esp32/devicetree.yaml
• Devices/generic-esp32c6/devicetree.yaml
• Devices/generic-esp32p4/devicetree.yaml
• Devices/generic-esp32s3/devicetree.yaml

✅ Files skipped from review due to trivial changes (4)

• Devices/generic-esp32s3/devicetree.yaml
• Devices/generic-esp32c6/devicetree.yaml
• Devices/generic-esp32/devicetree.yaml
• Devices/generic-esp32p4/devicetree.yaml

[coderabbitai]

Actionable comments posted: 4

🧹 Nitpick comments (3)

Buildscripts/TactilitySDK/TactilitySDK.cmake (1)

1-5: Empty function stubs should be documented or removed.

The tactility_project() function and _tactility_project() function are empty stubs. If they serve a purpose (e.g., forward declarations or placeholders for future use), consider adding a comment. Otherwise, they add noise.

Tests/SdkIntegration/main/Source/main.c (1)

27-33: Headers included for validation only - consider adding a comment.

These driver headers appear to be included solely to validate SDK packaging rather than for actual use in the test. A brief comment would clarify intent.

📝 Suggested documentation

 `#include` <tactility/lvgl_module.h>

+// Driver headers included to validate SDK packaging
 `#include` <drivers/bm8563.h>
 `#include` <drivers/bmi270.h>

Buildscripts/release-sdk.py (1)

91-95: add_driver uses create_module_cmakelists — verify this is intentional.

The add_driver function (line 94) calls create_module_cmakelists(driver_name) to generate the CMakeLists.txt. This creates identical CMakeLists content for both drivers and modules. If drivers require different CMake configuration (e.g., different REQUIRES), consider creating a separate create_driver_cmakelists function.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 69a45870-e720-4b26-ae52-f82851b6030d

📥 Commits

Reviewing files that changed from the base of the PR and between aa954da and 4d245d4.

📒 Files selected for processing (6)

• Buildscripts/TactilitySDK/CMakeLists.txt
• Buildscripts/TactilitySDK/TactilitySDK.cmake
• Buildscripts/release-sdk.py
• Tests/SdkIntegration/CMakeLists.txt
• Tests/SdkIntegration/main/CMakeLists.txt
• Tests/SdkIntegration/main/Source/main.c

💤 Files with no reviewable changes (1)

• Buildscripts/TactilitySDK/CMakeLists.txt