Skip to content

fix(build-logic): release version reads -Pversion; bump to 1.23.0#32

Merged
THEROER merged 2 commits into
mainfrom
fix/release-version-bump
Jul 6, 2026
Merged

fix(build-logic): release version reads -Pversion; bump to 1.23.0#32
THEROER merged 2 commits into
mainfrom
fix/release-version-bump

Conversation

@THEROER

@THEROER THEROER commented Jul 6, 2026

Copy link
Copy Markdown
Owner

Two changes needed to cut the 1.23.0 release:

  • release task version fix: the target plugin overwrites project.version with the +<minecraft> suffix (e.g. 1.23.0+1.21.10), which the release tasks rejected as non-semver. Read the raw -Pversion from the start parameter instead.
  • bump: gradle.properties version 1.22.01.23.0.

1.23.0 is a minor: it ships the new consumer EmbedMode API (replacing the boolean embed flag), runtime duplicate-MagicUtils detection on Bukkit, the live consumer registry / clickable /mu mods, and the bukkit-bundle as a Paper plugin.

Summary by Sourcery

Adjust release version handling and bump project version for the 1.23.0 release.

Build:

  • Make release tasks read the raw -Pversion from Gradle start parameters instead of the modified project.version.
  • Update gradle.properties to set the project version to 1.23.0.

THEROER added 2 commits July 6, 2026 18:13
…t.version

The target plugin overwrites project.version with the +<minecraft> suffix,
so the release tasks saw 1.23.0+1.21.10 and rejected it as non-semver. Read
the raw -Pversion from the start parameter instead, which the target plugin
does not touch.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@sourcery-ai

sourcery-ai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts release task version resolution to read the raw -Pversion from Gradle’s start parameters instead of project.version, and bumps the project version to 1.23.0 for the upcoming release.

File-Level Changes

Change Details Files
Release tasks now read the release version from the Gradle start parameter -Pversion instead of project.version to avoid the target plugin’s non-semver suffix.
  • Define versionProvider using gradle.startParameter.projectProperties["version"] rather than project.findProperty("version")
  • Preserve existing GradleException behavior when -Pversion is missing, but tailor it specifically to the start-parameter lookup
  • Document why project.version cannot be used due to the + suffix breaking semver validation
build-logic/src/main/kotlin/dev/ua/theroer/magicutils/build/release/MagicUtilsReleaseTasks.kt
Bump the project’s declared version to 1.23.0 for the new release.
  • Update the version property from 1.22.0 to 1.23.0 in gradle.properties
gradle.properties

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since the release flow now depends strictly on -Pversion, consider adding a sanity check that this raw value matches the gradle.properties version or has no Minecraft suffix to catch misconfigured releases early.
  • The versionProvider currently assumes startParameter.projectProperties["version"] is a String; if there’s any chance of other types being passed, a safe cast (as? String) with a clearer error message for non-string values could make failures less confusing.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the release flow now depends strictly on `-Pversion`, consider adding a sanity check that this raw value matches the `gradle.properties` version or has no Minecraft suffix to catch misconfigured releases early.
- The `versionProvider` currently assumes `startParameter.projectProperties["version"]` is a String; if there’s any chance of other types being passed, a safe cast (`as? String`) with a clearer error message for non-string values could make failures less confusing.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@THEROER THEROER merged commit 083aebd into main Jul 6, 2026
8 checks passed
@THEROER THEROER deleted the fix/release-version-bump branch July 10, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant