fix(build-logic): release version reads -Pversion; bump to 1.23.0#32
Merged
Conversation
…t.version The target plugin overwrites project.version with the +<minecraft> suffix, so the release tasks saw 1.23.0+1.21.10 and rejected it as non-semver. Read the raw -Pversion from the start parameter instead, which the target plugin does not touch.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts release task version resolution to read the raw -Pversion from Gradle’s start parameters instead of project.version, and bumps the project version to 1.23.0 for the upcoming release. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since the release flow now depends strictly on
-Pversion, consider adding a sanity check that this raw value matches thegradle.propertiesversion or has no Minecraft suffix to catch misconfigured releases early. - The
versionProvidercurrently assumesstartParameter.projectProperties["version"]is a String; if there’s any chance of other types being passed, a safe cast (as? String) with a clearer error message for non-string values could make failures less confusing.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the release flow now depends strictly on `-Pversion`, consider adding a sanity check that this raw value matches the `gradle.properties` version or has no Minecraft suffix to catch misconfigured releases early.
- The `versionProvider` currently assumes `startParameter.projectProperties["version"]` is a String; if there’s any chance of other types being passed, a safe cast (`as? String`) with a clearer error message for non-string values could make failures less confusing.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes needed to cut the 1.23.0 release:
project.versionwith the+<minecraft>suffix (e.g.1.23.0+1.21.10), which the release tasks rejected as non-semver. Read the raw-Pversionfrom the start parameter instead.gradle.propertiesversion1.22.0→1.23.0.1.23.0 is a minor: it ships the new consumer
EmbedModeAPI (replacing the boolean embed flag), runtime duplicate-MagicUtils detection on Bukkit, the live consumer registry / clickable/mu mods, and the bukkit-bundle as a Paper plugin.Summary by Sourcery
Adjust release version handling and bump project version for the 1.23.0 release.
Build: