Add the WM_CLASS property to the BizHawk window#4782
Conversation
YoshiRulz
added
App: EmuHawk
YoshiRulz
left a comment
YoshiRulz
left a comment
There was a problem hiding this comment.
There are a bunch of lint problems too, but you can ignore those until we finalise the design.
| StepRunLoop_Throttle(); | ||
|
|
||
| //Code to set WM_CLASS only need be run once, but must be run after the application has rendered at least once | ||
| if(_runWMSetOnce && OSTailoredCode.CurrentOS==OSTailoredCode.DistinctOS.Linux) |
There was a problem hiding this comment.
There are a few possible places for init code, mainly the constructor and the Load handler MainForm_Load.
| if(_runWMSetOnce && OSTailoredCode.CurrentOS==OSTailoredCode.DistinctOS.Linux) | ||
| { | ||
| string wmclass = _argParser.wmClassName is not null ? _argParser.wmClassName : "BizHawk"; | ||
| OSTailoredCode.SetWMClass(_x11Display,wmclass); |
There was a problem hiding this comment.
I think this is meant to be a lazy-initialised variable:
BizHawk/src/BizHawk.Client.EmuHawk/MainForm.cs
Lines 4866 to 4868 in bd7626e
So you should do the same here.
| return stdout.ReadLine()!; | ||
| } | ||
|
|
||
| public static void SetWMClass(IntPtr x11Display, string className) |
| public static void SetWMClass(IntPtr x11Display, string className) | ||
| { | ||
| //Setup the ClassHint | ||
| var wmSet = new XlibImports.XClassHint{res_name = Marshal.StringToCoTaskMemAnsi("BizHawk"), res_class = Marshal.StringToCoTaskMemAnsi(className)}; |
There was a problem hiding this comment.
Can you explain why the same string needs to be passed twice?
There was a problem hiding this comment.
The WM_CLASS property is made up of two parts (name and class) - both need to be provided - they can be different/unique however it is somewhat common to see application name used in both fields (as I have here as the default behaviour).
|
|
||
| private static readonly Option<string?> OptionWMClass = new ("--wmclass") | ||
| { | ||
| Description = "set a custom WM_CLASS for this Bizhawk initiation, Linux only.", |
There was a problem hiding this comment.
Why is this a CLI flag? When should a user be changing it? If it's for vendoring, we already have VersionInfo.CustomBuildString.
There was a problem hiding this comment.
My initial reasoning for looking into adding WM_CLASS was to help improve BizHawk's integration with the DE (I use KDE). By defining a WM_CLASS we can hint StartupWMClass for example in .desktop files.
In allowing WM_CLASS to be set in a CLI arg it is then feasible to distinguish between different installs of Bizhawk (for example, a Kaizo Ironmon setup and a regular Bizhawk install)
2 participants
Adds a set of calls to XLIB to set a WM_CLASS on Linux for BizHawk; runs once but has to be run in the main loop as the application needs to be fully loaded and rendering (If there is a better place to put this, please do let me know!). Also added support for defining the WM_CLASS to use via a CLI argument.
CI suites ran; I think that's all I needed to do?
Check if completed: