corrections for the multiple cameras case - #38
Open
janrosell wants to merge 10 commits into
Open
Conversation
… the sensor names to deal with multicmaera worlds
…he prefix parameter to tune the sensor names
…asheet.pdf document
…0_Series_Datasheet.pdf document
SyrianSpock
approved these changes
Mar 4, 2020
SyrianSpock
left a comment
SyrianSpock
left a comment
Owner
There was a problem hiding this comment.
Code looks OK, realistically I don't have time to test this locally so I'll just merge
Owner
|
@janrosell Please fix the conflicts so I can merge the PR |
|
Hi i have another branch with the similar fix, but if this one is more complete then this is good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fork has made it possible to correctly use several cameras.
Different cameras were publishing different topics but with the same image. This was due to the fact that the prefix was not passed to the RealSensePlugin and there the sensor manager had several cameras with the same name and always took the first one. The frame name has also been updated accordingly.
Also the resolution of the camera and FOV have been changed according to the specifications.
An example has been provided where two cameras look at a chessboard: