Fix inline local declarations in assignment expressions#218
Open
OnlyYu1996 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97.
Fixes #99.
This teaches the OpenCL writer to hoist local declarations that appear inside inline assignment expressions to the start of the current block. The original inline assignment expression is then emitted as a normal assignment, avoiding invalid OpenCL such as
result = int assignMe = valueand avoiding the previous CodeGenException for declarations in argument expressions.The scan deliberately skips for-header and arbitrary-scope composites so existing scoped declarations keep their current output shape.
Validation:
mvn -q -Dstyle.color=never -Dtest=AssignAndPassAsParameterSimpleTest,FirstAssignInExpression2Test,AssignAndPassAsParameterTest,FirstAssignInExpressionTest testmvn -q -Dstyle.color=never -Dtest=com.aparapi.codegen.test.*Test testmvn -q -Dstyle.color=never -DskipTests test-compilegit diff --check