Skip to content

Address PR #39 footer review comments in Landing page#45

Draft
mjamesbond with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-comments-in-review-thread
Draft

Address PR #39 footer review comments in Landing page#45
mjamesbond with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-comments-in-review-thread

Conversation

Copilot AI commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

This PR implements all requested changes from the linked review thread on src/pages/Landing.tsx. It resolves two footer issues: ineffective i18n fallback logic and conflicting hover transform behavior between Tailwind and Framer Motion.

  • i18n fallback handling

    • Replaced t("footer.crafted_by") || "CRAFTED BY" with t(..., { defaultValue }) so fallback text is controlled by i18n as requested.
  • Footer link hover transform ownership

    • Removed Tailwind hover:scale-105 from the motion.a class list.
    • Moved scale into Framer Motion so both hover transforms are applied consistently from whileHover.
  • Regression coverage

    • Added src/pages/Landing.footer-review.test.ts to lock both review fixes (defaultValue usage and Framer-only hover scaling path).
<p>{t("footer.crafted_by", { defaultValue: "CRAFTED BY" })}</p>

<motion.a
  className="... transition-transform duration-300 ..."
  whileHover={{ y: -2, scale: 1.05 }}
/>

Copilot AI changed the title [WIP] Fix code according to review comments Address PR #39 footer review comments in Landing page Jun 8, 2026
Copilot AI requested a review from mjamesbond June 8, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants