Address PR #39 footer review comments in Landing page#45
Draft
mjamesbond with Copilot wants to merge 2 commits into
Draft
Address PR #39 footer review comments in Landing page#45mjamesbond with Copilot wants to merge 2 commits into
mjamesbond with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code according to review comments
Address PR #39 footer review comments in Landing page
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements all requested changes from the linked review thread on
src/pages/Landing.tsx. It resolves two footer issues: ineffective i18n fallback logic and conflicting hover transform behavior between Tailwind and Framer Motion.i18n fallback handling
t("footer.crafted_by") || "CRAFTED BY"witht(..., { defaultValue })so fallback text is controlled by i18n as requested.Footer link hover transform ownership
hover:scale-105from themotion.aclass list.whileHover.Regression coverage
src/pages/Landing.footer-review.test.tsto lock both review fixes (defaultValue usage and Framer-only hover scaling path).