feat: declare strict types and support php 8.4#205
Closed
shakaran wants to merge 1 commit into
Closed
Conversation
sadikoff
suggested changes
May 27, 2025
sadikoff
left a comment
sadikoff
left a comment
There was a problem hiding this comment.
wow nice strict types is always great, however I can't fully agree with use statements for global namespace classes, I'd prefer to keep them like \Exeption() in the code, it's easier to understand which exact Exception are you using
Author
|
Closing this in favour of #206 with the changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied rules:
DeclareStrictTypes
ReadOnlyProperty
ReadOnlyClass
CatchExceptionNameMatchingType
FlipTypeControlToUseExclusiveType
AddOverrideAttributeToOverriddenMethods
AddClosureVoidReturnTypeWhereNoReturn
RemoveEmptyClassMethod
RemoveUnusedConstructorParam