Implement Zag Script, zagd planning, and Linux x86 milestones - #2
Open
micahcooley wants to merge 452 commits into
Open
Implement Zag Script, zagd planning, and Linux x86 milestones#2micahcooley wants to merge 452 commits into
micahcooley wants to merge 452 commits into
Conversation
|
Important Review skippedToo many files! This PR contains 882 files, which is 782 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (17)
📒 Files selected for processing (882)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note The number of changes in this pull request is too large for Gemini Code Assist to generate a review. |
The explain/witness rewrite accumulated every manifest line via _zag_str_concat on []u8, reallocating the whole buffer per subexpression. On the full compiler manifest (~131k lines) this O(n^2) bump-allocator growth blew past the 16 GB runner and OOM-killed the bootstrap step. Convert the lines/call_lines/body accumulators (and the sm_calls_*/ sm_expr_witness/sm_value_facts_body helpers) to append-based ArrayList[u8] via the existing aj() helper. Output is byte-identical; bootstrap peak drops to ~1 GiB and the znc seed reaches fixpoint. Refresh the znc seed to the reproducible fixpoint built from the fixed source. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Authority and safety
Regular Zag remains advisory and source-preserving. Zag Script applies defaults only where source choices are unspecified. Foreground compilation remains authoritative without zagd. Unsupported i686 and optimizer behavior fails closed and remains documented.
Validation
Remaining documented boundaries
This PR does not claim universal memory safety, a complete ownership system, universal deep optimization, full foreign i686 ABI coverage, ARM support, or full x86-family completion.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is enabled.