[UPMERGE] 2.0 -> 2.1#631
Open
SyliusBot wants to merge 7 commits into
Open
Conversation
Adds telemetry policy and `sylius/telemetry-bundle` as a hard dependency. - `TELEMETRY_POLICY.md` — describes scope, purpose, and conditions of telemetry data collection - `composer.json` — requires `sylius/telemetry-bundle: ^1.0` - `README.md` — telemetry notice pointing to the policy file Related: Sylius/Sylius#18588
AdminBundle's modal-portal.js moves .modal elements to <body> on show.bs.modal, detaching the modal from its LiveComponent wrapper. This broke the data-action="live#action:prevent" binding, causing the sandbox credential form to fall back to a plain HTTP POST. Fix by intercepting show.bs.modal in the capture phase (before modal-portal.js runs in the bubbling phase), moving the entire LiveComponent wrapper to <body> instead of just the modal, and restoring it to its original DOM position on hidden.bs.modal via a comment-node placeholder. Also fix getDataModelValue() visibility (protected) and return type (string), drop Sylius ~2.0.1 from the build matrix, update the winzou_state_machine CI entry to use Sylius ~2.2.0 / Symfony ^7.4, and add a Behat scenario verifying PayPal is sorted first at checkout. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AdminBundle's modal-portal.js moves .modal elements to <body> on show.bs.modal, detaching the modal from its LiveComponent wrapper. This broke the data-action="live#action:prevent" binding, causing the sandbox credential form to fall back to a plain HTTP POST. Fix by intercepting show.bs.modal in the capture phase (before modal-portal.js runs in the bubbling phase), moving the entire LiveComponent wrapper to <body> instead of just the modal, and restoring it to its original DOM position on hidden.bs.modal via a comment-node placeholder. Also fix getDataModelValue() visibility (protected) and return type (string), drop Sylius ~2.0.1 from the build matrix, update the winzou_state_machine CI entry to use Sylius ~2.2.0 / Symfony ^7.4, and add a Behat scenario verifying PayPal is sorted first at checkout. | Q | A | --------------- | ----- | Branch? | 2.0 | Bug fix? | yes | New feature? | no
The component is registered as sylius_paypal:create_sandbox_modal in services.xml, not sylius_paypal_sandbox_modal. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been generated automatically.
Remember! The upmerge should always be merged using the
Merge pull requestbutton.In case of conflicts, resolve them manually: