Proxy: fix proxy settings not reactively applied in UnauthorizedAccount#180
Open
mvsrcdst wants to merge 1 commit into
Open
Proxy: fix proxy settings not reactively applied in UnauthorizedAccount#180mvsrcdst wants to merge 1 commit into
mvsrcdst wants to merge 1 commit into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If user changes/switch proxy settings mid-login before authorization completes, the change isn't picked up and the app keeps using the proxy config it had at login start. Only workaround: restart the app.
Root cause:
Account(post-login) already has a reactive subscription toSharedDataKeys.proxySettingsthat pushes proxy changes into the live MTProto network environment.UnauthorizedAccount(pre-login) had no equivalent, proxy settings were read once at init and effectively frozen for the rest of the login flow.Fix
Add the same reactive subscription to
UnauthorizedAccountthatAccountalready has:SharedDataKeys.proxySettings,distinctUntilChangedMTSocksProxySettingsTracked with
MetaDisposable, disposed indeinit.Impact
Switching/changing SOCKS5 proxy mid-login now takes effect immediately, no app restart needed.
Note
Part of tracking issue: #182
Testing