Video circles: add on-device transcription#178
Open
mvsrcdst wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144
Summary
SGLocalTranscriptionso both message types reuse the same code instead of duplicating itrequiresOnDeviceRecognitionwas set fromspeechRecognizer.supportsOnDeviceRecognition, but that propertyalways reads back
trueno matter what you assign it. So on-devicerecognition was forced for every locale. If the on-device model
wasn't downloaded, transcription just failed instead of falling back
to network recognition.
Screenshots
Video-circle message with transcribe button
Video-circle message with transcribed text
Testing
requiresOnDeviceRecognition: true), confirming genuine offline operation