Skip to content

Es/sse stream - #78

Open
ETSells wants to merge 2 commits into
integration/state-estims-telemetryfrom
ES/sse-stream
Open

Es/sse stream#78
ETSells wants to merge 2 commits into
integration/state-estims-telemetryfrom
ES/sse-stream

Conversation

@ETSells

@ETSells ETSells commented Aug 21, 2026

Copy link
Copy Markdown
Member

Description

Bugfixes/integration issues from SSE.

Issue Link

Parent: SunDevilRocketry/SDEC-API#24

Testing

  • Passes existing automated tests
  • Automated tests modified
  • Manual test performed

AI Disclosure (Required)

  • Was an AI agent used to synthesize a significant portion of the submitted code?
  • Do you understand that you are responsible for your contributions, regardless of whether they are generated or hand-written?

Scope of AI assistance: Used to debug a struct unpacking issue.

Please consider disclosing the specific tools you used (this part is optional):

  • Model: Claude 5.5 Sonnet
    • Thinking Level (if applicable):
    • Context Size (if applicable):
  • Harness: Claude Web Interface

Other

N/A

Reviewer Checklist

Standards

  • Follows FCF Architectural Standards
  • Follows SDR Coding Standards
  • Code complexity/function Size is minimized
  • Code is testable
  • Code is readable and commented properly
  • License terms are respected

Accuracy

  • Code implements the correct requirement (a.k.a. does the right thing)
  • Code is logically correct (a.k.a. does the thing right)

Error Handling

  • Potentially unsafe functions return a status code
  • Error returns properly handled
  • Fail-fast errors are only thrown when unsafe to continue software execution
  • Debug errors are thrown for exceptions where execution should still continue (to be noticed during development)

Memory

  • Stack allocated memory is scoped correctly
  • Heap allocated memory is not used
  • Statically/Globally allocated memory is minimized except when necessary
  • Pointers are used correctly
  • Concurrent access has been considered (especially by/from interrupt service routines)

Performance

  • Rate limiters are respected
  • Busy waiting is avoided in performance sensitive code
  • "Delay" calls are not used in performance sensitive code
  • If performance is negatively impacted, a justification is provided and the impact is quantified

@ETSells
ETSells changed the base branch from main to integration/state-estims-telemetry August 21, 2026 03:28
@ETSells
ETSells changed the base branch from integration/state-estims-telemetry to main August 21, 2026 03:29
@ETSells
ETSells requested a review from MasterUser43 August 21, 2026 03:29
@ETSells
ETSells changed the base branch from main to integration/state-estims-telemetry August 21, 2026 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant