GHI #112, #119 - Fix API data pipeline & add altitude tape [FV/typescript-rewrite] by ETSells · Pull Request #116 · SunDevilRocketry/Flight-Software-GUI

ETSells · 2026-07-05T23:12:32Z

Issues: #112, #119 (relates to: #44, #101)

Parent: SunDevilRocketry/Flight-Computer-Firmware#301

Description

Adds an altitude tape widget to the right of the renderer, fixes the new data pipeline from the API, adds the remaining data readouts to the sensor readings widget, and fixes some responsiveness issues.

Due to a lack of response on the original and the need to build on existing changes, additional features have been added on top of this PR:

Add display unit converters for altitude and acceleration
a. Ideally, we'll include settings page linkage once that exists, but for now this already helps unify our view/presenter framework a bit.
b. All unit converters implement an interface that defines the base functions, so polymorphism is possible.
c. The altitude converter also includes a ground reference "QFE" mode in addition to the usual sea-level reference "QNH" mode.

NOTE: Builds fail due to an issue that predates this PR and should be fixed by the owner of the target branch. No new errors are generated by this PR, and npm run dev still works.

▲ Next.js 16.2.9 (Turbopack)

  Creating an optimized production build ...
✓ Compiled successfully in 1823ms
  Running TypeScript  .Failed to type check.

./src/utils/mock.ts:1:16
Type error: Invalid module name in augmentation. Module 'papaparse' resolves to an untyped module at 'C:/Users/etsel/SDR/dashboard/node_modules/papaparse/papaparse.js', which cannot be augmented.

> 1 | declare module "papaparse";
    |                ^
  2 |
  3 | import Papa from "papaparse";
  4 | import type { RawSensorPacket } from "@/utils/api";
Next.js build worker exited with code: 1 and signal: null

Originator Checklist

Title matches the form "GHI # - []"
Target branch is correct
Unit Tests have been posted in issue <if applicable,can be super simple like a screenshot>
Issue has been linked to this PR
Changes generate no new warnings
- merge main into your branch to resolve conflicts before opening PR!

Not all features introduced here have a relevant issue.
No unit test framework exists for this project, so unit tests have not been written.
Manually performed system & integration tests.

ETSells · 2026-07-11T19:34:30Z

Parent has been moved out of draft state and is ready for review. One minor tweak was needed here, but this is also still ready

ETSells · 2026-08-17T20:05:23Z

@favillat Re-requesting review now that the base branch is ready to go.

ETSells · 2026-08-20T17:48:36Z

@NArmistead @MasterUser43 As this is top priority, I'm tagging both of you on the review as well. Please take a look and let me know if there's anything you don't feel you have sufficient expertise in.

…than world frame

…ult system units to feet/g-force for flight.

favillat

lgtm, just a few minor considerations and a couple questions.

favillat · 2026-08-21T05:21:28Z

+    METERS_TO_FEET = 3.280839895,
+    GRAVITY_MPS = 9.80665
+}
+export default ConversionFactors;


It might be worth converting this to const instead of an enum

export const ConversionFactors = { METERS_TO_FEET: 3.xx, GRAVITY_MPS: 9.xx, } as const;

favillat · 2026-08-21T05:27:15Z

+ */
+interface UnitsHandler {
+    /* Shared members for unitsHandler. Not typed for inheritance reasons. */
+    systemUnits: any


I'm curious as to what inheritance reasons? we could try doing a generic type to make it generally safer.

favillat · 2026-08-21T05:38:18Z

+                break; /* SI/input units */
+
+            default:
+                console.error("Invalid altitude units.") /* intentional fallthrough to G */


I'm assuming this was meant to be "Invalid acceleration units", further down there are a few more instances of this aswell

favillat · 2026-08-21T05:43:46Z

+     * @returns A string with the output value and its associated units
+     */
+    getDisplayString(input: number): string {
+        if(this.systemUnits == AccelerationUnits.G_FORCE)


Nitpicky but it might be better to do strict equality checks here (===), they're faster and cleaner

favillat · 2026-08-21T05:45:22Z

+        }
+
+        /* Extra step for altitude: reference mode */
+        if(this.referenceElevation >= 0 && this.mode == AltitudeMode.QFE) {


same strict equality check comment as before, just makes this more predictable and doesn't hurt

favillat · 2026-08-21T05:59:30Z

+                if (this.referenceElevation < 0) {
+                    break; /* use QNH if no reference elevation defined. assumes we'd never launch from below sea level */
+                }
+                input -= this.referenceElevation; /* negative altitudes allowed */


This having no break here would mean any time we use QFE, we would default and log "Invalid altitude reference mode.". Instead why not skip the fall-thru all together and just let typescript types deal with issues? it might make future debugging a bit easier.

NArmistead

I'm not going to claim to understand everything that's going on but lgtm as far as I can tell

NArmistead · 2026-08-21T06:02:05Z

+ * Firmware uses the NED (North-East-Down) convention of X: roll,
+ * Y: pitch, Z: yaw, so at the identity orientation the model's 
+ * nose must point along Three's +X (see baseQuat below). A 90°
+ * rotation on the +X axis aligns the firmware's body frame with 


ehh some of this comment is kinda redundant (i wrote it)

NArmistead · 2026-08-21T06:03:35Z

+ *     similarity transform (conjugation), since firmware's body-frame
+ *     axes are not the same axes as Three's world frame axes. This is
+ *     NOT the same as composing two rotations (simple multiplication) —
+ *     conjugation is what's required when changing the basis a


aren't we using the inverse here not the conjugate?

NArmistead · 2026-08-21T06:07:20Z

is this working correctly now? i haven't tested on hardware since i fixed(?) it

ETSells requested a review from favillat July 5, 2026 23:12

ETSells mentioned this pull request Jul 6, 2026

State Estimations & Telemetry Updates SunDevilRocketry/Flight-Computer-Firmware#301

Open

24 tasks

ETSells changed the title ~~GHI N/A - Fix API data pipeline & add altitude tape [FV/typescript-rewrite]~~ GHI 112 - Fix API data pipeline & add altitude tape [FV/typescript-rewrite] Jul 6, 2026

ETSells changed the title ~~GHI 112 - Fix API data pipeline & add altitude tape [FV/typescript-rewrite]~~ GHI #112 - Fix API data pipeline & add altitude tape [FV/typescript-rewrite] Jul 6, 2026

ETSells linked an issue Jul 6, 2026 that may be closed by this pull request

Integration: Upgrade to Quats #112

Open

ETSells mentioned this pull request Jul 19, 2026

Telemetry: Implement a message to give the baro offsets to the dashboard SunDevilRocketry/mod#137

Open

ETSells linked an issue Jul 20, 2026 that may be closed by this pull request

Feature: Display unit conversion #119

Open

ETSells changed the title ~~GHI #112 - Fix API data pipeline & add altitude tape [FV/typescript-rewrite]~~ GHI #112, #119 - Fix API data pipeline & add altitude tape [FV/typescript-rewrite] Jul 20, 2026

ETSells mentioned this pull request Jul 20, 2026

Feature: Display unit conversion #119

Open

ETSells force-pushed the integration/state-estims-telemetry branch from f1f8190 to 621937c Compare August 17, 2026 19:51

ETSells requested review from favillat and removed request for favillat August 17, 2026 20:05

ETSells requested review from MasterUser43 and NArmistead August 20, 2026 17:47

Base automatically changed from FV/typescript-rewrite to main August 20, 2026 17:57

ETSells and others added 6 commits August 20, 2026 10:57

Fix the dashboard data pipeline

a1064da

Add altitude tape widget & fix some responsiveness issues

b2b04db

Fix the renderer to take input with respect to the body frame rather …

e67b452

…than world frame

Add unit conversion utility based on a configurable system unit. Defa…

5133acb

…ult system units to feet/g-force for flight.

Replace acc_z with acc_x (thrust axis)

77fc40b

Correct change-of-basis for rocket render

0f55948

favillat force-pushed the integration/state-estims-telemetry branch from 621937c to 0f55948 Compare August 20, 2026 17:57

favillat reviewed Aug 21, 2026

View reviewed changes

NArmistead approved these changes Aug 21, 2026

View reviewed changes

Uh oh!

Conversation

ETSells commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues: #112, #119 (relates to: #44, #101)

Description

Originator Checklist

Uh oh!

ETSells commented Jul 11, 2026

Uh oh!

ETSells commented Aug 17, 2026

Uh oh!

ETSells commented Aug 20, 2026

Uh oh!

favillat left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NArmistead left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ETSells commented Jul 5, 2026 •

edited

Loading