chore(OSC-1274): Update best practices for batching#6683
Open
ravishankar-sumo wants to merge 4 commits into
Open
chore(OSC-1274): Update best practices for batching#6683ravishankar-sumo wants to merge 4 commits into
ravishankar-sumo wants to merge 4 commits into
Conversation
ravishankar-sumo
requested review from
a team,
JV0812,
amee-sumo,
kimsauce and
mafsumo
as code owners
4 tasks
Collaborator
|
Hi @ravishankar-sumo , thank you for submitting! Could you please add the associated Jira ticket link to your PR description? @amee-sumo tagging you as this is |
jagan2221
reviewed
May 13, 2026
jagan2221
reviewed
May 13, 2026
jagan2221
reviewed
May 13, 2026
kimsauce
reviewed
May 20, 2026
kimsauce
reviewed
May 20, 2026
ravishankar-sumo
force-pushed
the
rs/batching-migration
branch
2 times, most recently
from
8f22eba to
7fafc1e
Compare
jagan2221
approved these changes
Jun 2, 2026
Co-authored-by: Kim Pohas <56411016+kimsauce@users.noreply.github.com>
Co-authored-by: Kim Pohas <56411016+kimsauce@users.noreply.github.com>
ravishankar-sumo
force-pushed
the
rs/batching-migration
branch
from
7fafc1e to
80b9950
Compare
kimsauce
reviewed
Jun 5, 2026
| #### Queue Size | ||
| When an exporter is preceded by a batch processor, `sending_queue.queue_size` represents the number of batches produced by the batch processor. With exporter-side batching, the batch processor is removed, so `sending_queue.queue_size` instead represents the number of individual records. As a result, if the queue size is not adjusted accordingly, the queue may fill up more quickly and potentially lead to data loss. | ||
|
|
||
| To avoid this, it is recommended to increase `sending_queue.queue_size` by a factor equal to the batch processor’s `send_batch_size`. |
Collaborator
There was a problem hiding this comment.
Suggested change
| To avoid this, it is recommended to increase `sending_queue.queue_size` by a factor equal to the batch processor’s `send_batch_size`. | |
| To avoid this, we recommend increasing `sending_queue.queue_size` by a factor equal to the batch processor’s `send_batch_size`. |
kimsauce
reviewed
Jun 5, 2026
| To avoid this, it is recommended to increase `sending_queue.queue_size` by a factor equal to the batch processor’s `send_batch_size`. | ||
|
|
||
| ##### Example configuration | ||
| Assuming we have a batch processor with config |
Collaborator
There was a problem hiding this comment.
Suggested change
| Assuming we have a batch processor with config | |
| If you have a batch processor configured as follows: |
kimsauce
reviewed
Jun 5, 2026
| send_batch_max_size: 2_048 | ||
| ``` | ||
|
|
||
| We have the `sending_queue.queue_size` configured as, |
Collaborator
There was a problem hiding this comment.
Suggested change
| We have the `sending_queue.queue_size` configured as, | |
| And the `sending_queue.queue_size` configured as: |
kimsauce
reviewed
Jun 5, 2026
| queue_size: 1000 | ||
| ``` | ||
|
|
||
| The new config should be, |
Collaborator
There was a problem hiding this comment.
Suggested change
| The new config should be, | |
| You'd need to update to the following configuration: |
kimsauce
reviewed
Jun 5, 2026
Comment on lines
+585
to
+587
| send_batch_size: 1_024 | ||
| timeout: 1s | ||
| send_batch_max_size: 2_048 |
Collaborator
There was a problem hiding this comment.
should the underscores be removed for consistency with the other send_batch_size and send_batch_max_size instances?
Suggested change
| send_batch_size: 1_024 | |
| timeout: 1s | |
| send_batch_max_size: 2_048 | |
| send_batch_size: 1024 | |
| timeout: 1s | |
| send_batch_max_size: 2048 |
kimsauce
reviewed
Jun 5, 2026
| send_batch_max_size: 10000 | ||
| ``` | ||
|
|
||
| The new config should be, |
Collaborator
There was a problem hiding this comment.
Suggested change
| The new config should be, | |
| You'd need to migrate them to the exporter configuration as follows: |
kimsauce
reviewed
Jun 5, 2026
| queue_size: 1024000 ## = 1000 * 1024 | ||
| ``` | ||
| #### Batch Size | ||
| The batching logic is moved from processor to exporter so if you have custom configured the batch size like, |
Collaborator
There was a problem hiding this comment.
Suggested change
| The batching logic is moved from processor to exporter so if you have custom configured the batch size like, | |
| If your batch processor has custom batch size settings like the example below: |
kimsauce
requested changes
Jun 5, 2026
Collaborator
kimsauce
left a comment
kimsauce
left a comment
There was a problem hiding this comment.
@ravishankar-sumo just had some minor formatting/wording suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request...
Select the type of change
Ticket (if applicable)