Cap failure reason length and strip newlines in TransferFailureStore - #125
Merged
Conversation
TransferFailureStore.Add now sanitizes the Reason field before storing: replace newline and carriage-return characters with spaces, then truncate to 200 characters. Null or whitespace-only reasons fall back to the existing default string. Fixes #123
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TransferFailureStore.Add now sanitizes the Reason field at the single entry gate for all failure notices:
All current Nimbus-produced reasons are well under 100 characters. The cap guards against plugin CancelReason text or exception messages reaching a player's screen as a paragraph.
Three tests added: newline stripping, length cap, null fallback. All 312 registry tests pass.
Fixes #123