You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I find that this is related with #112 again. And I think maybe it's necessary to add more tests, and unify the access to properties. All the accesses should be limited with the access provided by com.stratio.datasource.util.Config.
I hope this time there will be no more paring problems, and I try my best to keep the original structure. In the com.stratio.datasource.mongodb.client.MongodbClientFactoryTest, I changed the way to init configurations since I think it's good to init configuration only from MongodbConfigBuilder and the old short cut way is imcompatitable with the new change. @pfcoperez plz check this pull request, it passes the current project tests, but I'm not very sure it covers all the problems, maybe need more tests and documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It resolves #126 and related parsing problems, #112 and #119 .