Issue 5886 improvements by Crabcyborg · Pull Request #3221 · Strategy11/formidable-forms

Crabcyborg · 2026-08-05T17:51:29Z

No description provided.

coderabbitai · 2026-08-05T17:51:37Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a8e7bff1-e1c8-4e95-8047-cde5fb7444ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

deepsource-io · 2026-08-05T17:52:26Z

DeepSource Code Review

We reviewed changes in 7fd9665...b28445d on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Aug 5, 2026 5:51p.m.	Review ↗
JavaScript		Aug 5, 2026 5:51p.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-08-05T17:52:28Z

 			$invalid_msg .= "<ul>$field_error_messages</ul>";
 		}
+
 		return apply_filters( 'frm_invalid_error_message', $invalid_msg, $args );


Function apply_filters invoked with 3 parameters, 2 required

The function call is not valid, which will result in a fatal runtime error.

deepsource-io · 2026-08-05T17:52:28Z

+		);
+
+		// The base invalid message is wrapped in a span, and the links are inside a list.
+		$this->assertStringContainsString( '<ul>', $message );


Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T17:52:28Z

+			)
+		);
+
+		$this->assertStringContainsString( '<li><a href="#field_repeated_text-2">Repeated text is required</a></li>', $message );


Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T17:52:28Z

+	 * @covers FrmFormsHelper::get_invalid_error_message
+	 */
+	public function test_get_invalid_error_message_builds_clickable_field_links() {
+		$this->form = $this->factory->form->create_and_get();


Access to an undefined property test_FrmFormsHelper::$factory

The property you are trying to access is not defined and will cause unexpected behavior when used.

deepsource-io · 2026-08-05T17:52:28Z

+
+		// The base invalid message is wrapped in a span, and the links are inside a list.
+		$this->assertStringContainsString( '<ul>', $message );
+		$this->assertStringContainsString( '<li><a href="#field_my_text">Text is required</a></li>', $message );


Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T17:52:29Z

+	 * @covers FrmFormsHelper::get_invalid_error_message
+	 */
+	public function test_get_invalid_error_message_escapes_output() {
+		$this->form = $this->factory->form->create_and_get();


Access to an undefined property test_FrmFormsHelper::$factory

The property you are trying to access is not defined and will cause unexpected behavior when used.

deepsource-io · 2026-08-05T17:52:29Z

+			)
+		);
+
+		$this->assertStringNotContainsString( '<script>alert(1)</script>', $message );


Call to an undefined method test_FrmFormsHelper::assertStringNotContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T17:52:29Z

+		);
+
+		$this->assertStringNotContainsString( '<script>alert(1)</script>', $message );
+		$this->assertStringContainsString( '&lt;script&gt;', $message );


Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T17:52:29Z

+	 * @covers FrmFormsHelper::get_invalid_error_message
+	 */
+	public function test_get_invalid_error_message_handles_repeater_row_keys() {
+		$this->form = $this->factory->form->create_and_get();


Access to an undefined property test_FrmFormsHelper::$factory

The property you are trying to access is not defined and will cause unexpected behavior when used.

deepsource-io · 2026-08-05T17:52:29Z

+	 * @return int
+	 */
+	private function create_field_with_key( $type, $field_key ) {
+		return $this->factory->field->create(


Access to an undefined property test_FrmFormsHelper::$factory

The property you are trying to access is not defined and will cause unexpected behavior when used.

deepsource-io · 2026-08-05T18:09:41Z

DeepSource Code Review

We reviewed changes in 7fd9665...62490e8 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Aug 5, 2026 7:15p.m.	Review ↗
JavaScript		Aug 5, 2026 7:15p.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-08-05T18:10:02Z

+				'class'    => 'frm_message',
+			)
+		);
+		$this->assertStringContainsString( 'role="status"', $default );


Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T18:10:02Z

+				'role'     => 'alert',
+			)
+		);
+		$this->assertStringContainsString( 'role="alert"', $alert );


Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T18:10:02Z

+			)
+		);
+		$this->assertStringContainsString( 'role="alert"', $alert );
+		$this->assertStringNotContainsString( 'role="status"', $alert );


Call to an undefined method test_FrmFormsHelper::assertStringNotContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T18:10:02Z

+		);
+
+		// Scripts are removed entirely.
+		$this->assertStringNotContainsString( '<script', $message );


Call to an undefined method test_FrmFormsHelper::assertStringNotContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T18:10:02Z

+		// Scripts are removed entirely.
+		$this->assertStringNotContainsString( '<script', $message );
+		// Anchors in the message are stripped so they cannot nest inside the summary link.
+		$this->assertStringNotContainsString( 'https://evil.test', $message );


Call to an undefined method test_FrmFormsHelper::assertStringNotContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T18:10:02Z

+		);
+
+		// Hidden and user ID errors appear as plain list items, with no anchor to a non-focusable input.
+		$this->assertStringContainsString( '<li>Hidden is required</li>', $message );


Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T18:10:02Z

+
+		// Hidden and user ID errors appear as plain list items, with no anchor to a non-focusable input.
+		$this->assertStringContainsString( '<li>Hidden is required</li>', $message );
+		$this->assertStringContainsString( '<li>User ID is required</li>', $message );


Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T18:10:02Z

+		// Hidden and user ID errors appear as plain list items, with no anchor to a non-focusable input.
+		$this->assertStringContainsString( '<li>Hidden is required</li>', $message );
+		$this->assertStringContainsString( '<li>User ID is required</li>', $message );
+		$this->assertStringNotContainsString( '#field_my_hidden', $message );


Call to an undefined method test_FrmFormsHelper::assertStringNotContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T18:10:02Z

+		$this->assertStringContainsString( '<li>Hidden is required</li>', $message );
+		$this->assertStringContainsString( '<li>User ID is required</li>', $message );
+		$this->assertStringNotContainsString( '#field_my_hidden', $message );
+		$this->assertStringNotContainsString( '#field_my_user_id', $message );


Call to an undefined method test_FrmFormsHelper::assertStringNotContainsString()

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-08-05T18:10:02Z

+	 * @covers FrmFormsHelper::get_success_message
+	 */
+	public function test_get_success_message_role() {
+		$form = $this->factory->form->create_and_get();


Access to an undefined property test_FrmFormsHelper::$factory

The property you are trying to access is not defined and will cause unexpected behavior when used.

deepsource-io · 2026-08-05T18:55:43Z

+		 *
+		 * @return bool
+		 */
+		public static function field_on_current_page( $field ) {


Method FrmProFieldsHelper::field_on_current_page() should return bool but return statement is missing

This issue is raised if a method with a return type does not have a return statement of an appropriate type.

Issue 5886 improvements

b28445d

Crabcyborg added this to the 6.34 milestone Aug 5, 2026

Crabcyborg added run analysis run tests labels Aug 5, 2026

deepsource-io Bot reviewed Aug 5, 2026

View reviewed changes

Use role="alert" for AJAX errors, use kses on error message

c24a1da

deepsource-io Bot reviewed Aug 5, 2026

View reviewed changes

Crabcyborg added 4 commits August 5, 2026 15:33

Avoid linking to a field that is not on page or visible

4a6ff79

Fix some failing workflow issues

6e92a72

Shift some code

e3d6ef9

Run php cs fixer on stub

c1c2719

deepsource-io Bot reviewed Aug 5, 2026

View reviewed changes

Fix margin bottom issue in ul

62490e8

Crabcyborg merged commit cae5029 into issue-5886-improve_form_errors_accessibility Aug 5, 2026
16 of 19 checks passed

Crabcyborg deleted the issue_5886_improvements branch August 5, 2026 19:16

Uh oh!

Conversation

Crabcyborg commented Aug 5, 2026

Uh oh!

coderabbitai Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

deepsource-io Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Function apply_filters invoked with 3 parameters, 2 required

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Access to an undefined property test_FrmFormsHelper::$factory

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Access to an undefined property test_FrmFormsHelper::$factory

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmFormsHelper::assertStringNotContainsString()

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Access to an undefined property test_FrmFormsHelper::$factory

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Access to an undefined property test_FrmFormsHelper::$factory

Uh oh!

deepsource-io Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmFormsHelper::assertStringContainsString()

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmFormsHelper::assertStringNotContainsString()

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmFormsHelper::assertStringNotContainsString()

Uh oh!

deepsource-io Bot Aug 5, 2026

Choose a reason for hiding this comment

Call to an undefined method test_FrmFormsHelper::assertStringNotContainsString()

Uh oh!

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading

deepsource-io Bot commented Aug 5, 2026 •

edited

Loading

deepsource-io Bot commented Aug 5, 2026 •

edited

Loading