Work on adding show options to code list pop up

classes/controllers/FrmFormsController.php

@@ -1851,6 +1851,93 @@ private static function advanced_helpers( $atts ) {
 		return apply_filters( 'frm_advanced_helpers', $advanced_helpers, $atts );
 	}
 
+	/**
+	 * Adds a shortcode for each part of a multi-part field to the field shortcode list,
+	 * so a single part can be used on its own, like [25 show=first] for a Name field.
+	 *
+	 * @since x.x
+	 *
+	 * @param array $atts Includes 'field'.
+	 *
+	 * @return void
+	 */
+	public static function field_part_shortcodes( $atts ) {
+		$field = $atts['field'];
+
+		foreach ( self::get_field_parts( $field ) as $part => $label ) {
+			FrmFormsHelper::insert_opt_html(
+				array(
+					'id'        => $field->id . ' show=' . $part,
+					'key'       => $field->field_key . ' show=' . $part,
+					// Truncate the key on its own so the part stays readable.
+					'key_label' => FrmAppHelper::truncate( $field->field_key, 7 ) . ' show=' . $part,
+					'name'      => $field->name . ' (' . $label . ')',
+					'type'      => $field->type,
+					'class'     => 'frm-customize-list dropdown-item',
+				)
+			);
+			unset( $part, $label );
+		}
+	}
+
+	/**
+	 * Gets the parts of a multi-part field that can be shown on their own with a show= shortcode option.
+	 *
+	 * @since x.x
+	 *
+	 * @param stdClass $field
+	 *
+	 * @return array Part labels keyed by the show= option value.
+	 */
+	private static function get_field_parts( $field ) {
+		$parts = 'name' === $field->type ? self::get_name_field_parts( $field ) : array();
+
+		/**
+		 * Allows add-ons to add the parts of their own multi-part fields, like the Pro Address field.
+		 *
+		 * @since x.x
+		 *
+		 * @param array    $parts Part labels keyed by the show= option value.
+		 * @param stdClass $field The field the parts belong to.
+		 */
+		return apply_filters( 'frm_field_parts_for_shortcodes', $parts, $field );
+	}
+
+	/**
+	 * Gets the parts of a Name field that are in use. Only the parts included in the
+	 * selected name layout hold a value, so the rest would always show as blank.
+	 *
+	 * @since x.x
+	 *
+	 * @param stdClass $field
+	 *
+	 * @return array Part labels keyed by the show= option value, in layout order.
+	 */
+	private static function get_name_field_parts( $field ) {
+		$labels = array(
+			'first'  => __( 'First', 'formidable' ),
+			'middle' => __( 'Middle', 'formidable' ),
+			'last'   => __( 'Last', 'formidable' ),
+		);
+		$layout = FrmField::get_option( $field, 'name_layout' );
+
+		if ( ! $layout ) {
+			$layout = 'first_last';
+		}
+
+		// The layout option names the parts in use, in display order, like first_middle_last.
+		$parts = array();
+
+		foreach ( explode( '_', $layout ) as $part ) {
+			if ( isset( $labels[ $part ] ) ) {
+				$parts[ $part ] = $labels[ $part ];
+			}
+			unset( $part );
+		}
+
+		return $parts;
+	}
+
 	/**
 	 * Get an array of the options to display in the advanced tab
 	 * of the customization panel

classes/controllers/FrmHooksController.php

@@ -172,6 +172,7 @@ public static function load_admin_hooks() {
 		add_action( 'admin_menu', 'FrmFormsController::menu', 10 );
 		add_action( 'admin_head-toplevel_page_formidable', 'FrmFormsController::head' );
 		add_action( 'frm_after_field_options', 'FrmFormsController::logic_tip' );
+		add_action( 'frm_field_code_tab', 'FrmFormsController::field_part_shortcodes' );
 		add_filter( 'frm_fields_in_form_builder', 'FrmFormsController::update_form_builder_fields' );
 
 		add_filter( 'set-screen-option', 'FrmFormsController::save_per_page', 10, 3 );

classes/helpers/FrmFormsHelper.php

@@ -722,7 +722,7 @@ public static function insert_opt_html( $args ) {
 
 				echo esc_html( $truncated_name );
 				?>
-				<span>[<?php echo esc_html( FrmAppHelper::truncate( $args['key_label'] ?? $args['key'], 7 ) ); ?>]</span>
+				<span>[<?php echo esc_html( $args['key_label'] ?? FrmAppHelper::truncate( $args['key'], 7 ) ); ?>]</span>
 			</a>
 		</li>
 		<?php

js/src/admin/admin.js

@@ -3317,19 +3317,150 @@ window.frmAdminBuildJS = function() {
 				continue;
 			}
 
-			const anchor = document.createElement( 'a' );
-			anchor.setAttribute( 'href', '#' );
-			anchor.setAttribute( 'data-code', fields[ i ].fieldId );
-			anchor.classList.add( 'frm_insert_code' );
-			anchor.append( span( fields[ i ].fieldName ) );
-			anchor.append( span( { className: 'frm-text-sm frm-text-grey-500', text: `[${ fields[ i ].fieldId }]` } ) );
-
-			const li = document.createElement( 'li' );
-			li.classList.add( `frm-field-list-${ fieldId }` );
-			li.classList.add( `frm-field-list-${ fields[ i ].fieldType }` );
-			li.append( anchor );
-			list.append( li );
+			addCalcFieldLiToList( list, fieldId, fields[ i ].fieldId, fields[ i ].fieldName, fields[ i ].fieldType );
+
+			if ( ! isSummary ) {
+				// The summary field list is a list of fields to exclude, not a list of shortcodes, so field parts don't belong in it.
+				addFieldPartShortcodes( fields[ i ], fieldId, list );
+			}
+		}
+	}
+
+	/**
+	 * Adds shortcodes for the individual parts of a multi-part field, like [25 show=last] for a Name field.
+	 *
+	 * @since x.x
+	 *
+	 * @param {Object}      field   Field object containing fieldType, fieldId, and fieldName.
+	 * @param {string}      fieldId ID of the field the popup was opened for.
+	 * @param {HTMLElement} list    The 'ul' element that contains field shortcodes available for calculation.
+	 *
+	 * @return {void}
+	 */
+	function addFieldPartShortcodes( field, fieldId, list ) {
+		if ( ! isTextCalc( fieldId ) ) {
+			// Only a text calculation resolves a show= option. In any other type the shortcode
+			// is left as-is and the formula fails to evaluate, so don't offer the parts at all.
+			return;
+		}
+
+		maybeAddNamePartShortcodes( field, fieldId, list );
+
+		/**
+		 * Allows add-ons to add field part shortcodes to calculation popup.
+		 *
+		 * @since x.x
+		 *
+		 * @param {Object}      hookArgs                      Arguments passed to the hook.
+		 * @param {Object}      hookArgs.field                Field object containing fieldType, fieldId, and fieldName.
+		 * @param {string}      hookArgs.fieldId              ID of the field triggering the popup.
+		 * @param {HTMLElement} hookArgs.list                 The 'ul' element containing field shortcodes.
+		 * @param {Function}    hookArgs.addCalcFieldLiToList Helper function: addCalcFieldLiToList(list, fieldId, code, label, fieldType).
+		 */
+		wp.hooks.doAction( 'frm_add_calc_field_shortcodes', { field, fieldId, list, addCalcFieldLiToList } );
+	}
+
+	/**
+	 * Checks whether the calculation being edited is a text calculation.
+	 *
+	 * @since x.x
+	 *
+	 * @param {string} fieldId ID of the field the calculation belongs to.
+	 *
+	 * @return {boolean} True when the calculation type is text.
+	 */
+	function isTextCalc( fieldId ) {
+		const calcType = document.querySelector( `input[name="field_options[calc_type_${ fieldId }]"]:checked` );
+		return calcType ? 'text' === calcType.value : false;
+	}
+
+	/**
+	 * Adds shortcodes like [nameFieldId show=last] to the calculation popup.
+	 *
+	 * @since x.x
+	 *
+	 * @param {Object}      field   Field object containing fieldType, fieldId, and fieldName.
+	 * @param {string}      fieldId ID of the field the popup was opened for.
+	 * @param {HTMLElement} list    The 'ul' element that contains field shortcodes available for calculation.
+	 *
+	 * @return {void}
+	 */
+	function maybeAddNamePartShortcodes( field, fieldId, list ) {
+		if ( 'name' !== field.fieldType ) {
+			return;
 		}
+
+		Object.entries( getNamePartLabels( field.fieldId ) ).forEach(
+			( [ code, label ] ) => {
+				addCalcFieldLiToList(
+					list,
+					fieldId,
+					`${ field.fieldId } show=${ code }`,
+					`${ field.fieldName } (${ label })`,
+					field.fieldType
+				);
+			}
+		);
+	}
+
+	/**
+	 * Gets the parts of a Name field that are in use, keyed by their show= value.
+	 * Only the parts included in the selected name layout have a value to show.
+	 *
+	 * @since x.x
+	 *
+	 * @param {string} nameFieldId ID of the Name field.
+	 *
+	 * @return {Object} Part labels keyed by their show= value, in layout order.
+	 */
+	function getNamePartLabels( nameFieldId ) {
+		const labels = {
+			first: __( 'First', 'formidable' ),
+			middle: __( 'Middle', 'formidable' ),
+			last: __( 'Last', 'formidable' )
+		};
+		// The layout option names the parts in use, in display order, like first_middle_last.
+		const layout = document.getElementById( `name_layout_${ nameFieldId }` )?.value || 'first_last';
+		const parts = {};
+
+		layout.split( '_' ).forEach( part => {
+			if ( labels[ part ] ) {
+				parts[ part ] = labels[ part ];
+			}
+		} );
+
+		return parts;
+	}
+
+	/**
+	 * Adds a row to a calculation box's field shortcode list.
+	 *
+	 * @since x.x
+	 *
+	 * @param {HTMLElement} list      The 'ul' element that contains field shortcodes available for calculation.
+	 * @param {string}      fieldId   ID of the field the popup was opened for.
+	 * @param {string}      code      The shortcode to insert, without the brackets.
+	 * @param {string}      label     The name shown for the row.
+	 * @param {string}      fieldType Type of the field the shortcode belongs to.
+	 *
+	 * @return {void}
+	 */
+	function addCalcFieldLiToList( list, fieldId, code, label, fieldType ) {
+		const anchor = a( {
+			className: 'frm_insert_code',
+			children: [
+				span( label ),
+				span( { className: 'frm-text-sm frm-text-grey-500', text: `[${ code }]` } )
+			],
+			data: { code }
+		} );
+
+		list.append(
+			tag( 'li', {
+				className: `frm-field-list-${ fieldId } frm-field-list-${ fieldType }`,
+				child: anchor
+			} )
+		);
 	}
 
 	/**