Prepare 0.3.3 workflow and bug-fix release#54
Merged
Conversation
__post_init__ unconditionally overwrote gamma_pmp with T_Pmax_pct, so the constructor argument was silently ignored. Only default when gamma_pmp is None, matching the alpha_sc_abs/beta_voc_abs override pattern.
pvlib.inverter.pvwatts takes pdc0 as the DC-input limit, with the AC nameplate at eta_inv_nom * pdc0. dc_to_ac passed the intended AC nameplate (pv_peak / loading ratio) as pdc0, so output clipped ~4% below the rating used by InverterConfig.size_from_pv, the App energy balance, economics CAPEX sizing, and the CLI's ac_rating_kw. Derive pdc0 = nameplate / eta so all paths share one nameplate definition. App results are unchanged (its DC->AC conversion goes through simulate_energy_balance).
CostParams.sell_price_inflation and the cost_analysis_projection parameter existed, but there was no config key and neither the App runner nor the Monte Carlo runner passed it, so the public paths always projected export revenue with 0.0. Add the config key (default 0.0, bit-for-bit compatible), validate it, thread it through both projection call sites, expose a --sell-price-inflation CLI flag, and surface it in the dry-run summary.
Its datasheet points were NMOT ratings (800 W/m2, Mpp=415), but the CEC single-diode fit in breos.cec_fit interprets Vmp/Imp/Voc/Isc as STC values, so the entry produced silently wrong model parameters. Configs referencing it now hit the standard "not found. Available: ..." catalog error; Suntech_STP550S_STC is the same physical module rated at STC.
BatteryConfig defaulted to 0.80, the optimizer battery-spec fallback to 0.8, and the App config default to 0.70 — three surfaces, two values. Align on 0.70 (the documented App default). App and CLI behavior is unchanged since they always pass the config value explicitly; direct BatteryConfig users relying on the implicit 0.80 now get replacement at 70% SOH and can pass eol_percentage=0.8 to keep the old threshold.
Owner
Author
|
Additional update included in this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
breos sweepCLI workflow, example config, docs, and release-smoke coverageVerification
uv run pytest -q(254 passed)uv run ruff check breos testsuv run ruff format --check breos testsuv run sphinx-build -W -b html docs docs/_build/html