Let search find players with accented names - #7
Open
cschmertz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing "gonzalez", "durisic", "jakucionis", "salaun", or "dadiet" into the search box currently finds nothing. Hugo González, Nikola Đurišić, Kasparas Jakučionis, Tidjane Salaün, and Pacôme Dadiet are only reachable if you type the exact accented characters, which most keyboards can't do easily.
This adds a small normalizeName helper that strips accents from both the search query and the player names before matching. It uses NFD normalization plus a special case for Đ, which doesn't decompose like the others. Searching with the accents typed out still works the same as before.
One heads up: "demin" for Egor Demin still won't match after this alone, because his name in players.js contains a stray Cyrillic character. That's fixed in #6, and with both merged he becomes searchable.
Tested in the browser against every accented name in the data.