Feat add lebron to model used - #1
Open
MathieuK12 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I tried to add LEBRON model to you NBA Salary Model.
Why ? Because after talking with friends we talked about the fact that it would be awesome to compare to different model your good tool.
So I tried to add LEBRON to it. I'm not an expert when it comes to statistics and I talk with my friends to know how it should be implemented. We find out that LEBRON could use your formula : salary = total minutes / 1475 * (DARKO + 3) * 4.32 but this way : salary = total minutes / 1475 * (LEBRON + 2.7) * 4.32. Where the replacement-level player is -2.7 according to https://www.bball-index.com/lebron-introduction/
To be fair, I don't know if it matchs exactly your formula but it's what I tried. I don't know if it's the best way to implement it but I tried.
I did add to your constant PLAYER_DATA a prop named lebron and I added the data from basketball index at today's date. And then I use that data as you used the darko.
I opened this PR because I find it interesting not to be necessarily implemented.