feat(core): make openai and mlx embedding progress bars conditional on build mode#379
Open
pritpatel2412 wants to merge 2 commits into
Open
feat(core): make openai and mlx embedding progress bars conditional on build mode#379pritpatel2412 wants to merge 2 commits into
pritpatel2412 wants to merge 2 commits into
Conversation
Collaborator
|
@pritpatel2412 this pr looks good, could we fix linting so I can merge, thanks for contribution! |
Contributor
Author
|
Done Please check it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two existing
TODO: @yichuan-w add progress bar only in build modecomments insideembedding_compute.py.Changes Made
is_buildparameter tocompute_embeddings_openaiandcompute_embeddings_mlx.is_builddown from the maincompute_embeddingsdispatcher.tqdmprogress bar iterator only whenis_build=Truefor both OpenAI and MLX providers, preventing unnecessary log spam during non-build usage.Type of Change