feat: normalize semantic version strings for speech#39
Merged
Conversation
767d535 to
25be215
Compare
25be215 to
5be9a44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decimals_to_wordsonly splits the first decimal point, so a dotted version like0.7.0came out as "0 point 7.0" — it expanded the first dot and left a stray full stop mid-number. This adds a versions pass so multi-part version strings read naturally.Changes
versions_to_wordsruns just before the decimal split: every.in a 3-or-more-part number becomes "point" (0.7.0→ "0 point 7 point 0",1.20.3→ "1 point 20 point 3").3.14→ "3 point 1 4"), and a trailing sentence stop is preserved (upgrade to 1.2.3.).Testing
pytest— adds unit tests for spelling out versions, leaving decimals and trailing stops intact, plus an end-to-endnormalize_for_speechcheck;ruff check .clean.stackvox normalize "Upgraded to 0.7.0 today. Pi is 3.14."→Upgraded to 0 point 7 point 0 today. Pi is 3 point 1 4.Related issues
None.