-
Notifications
You must be signed in to change notification settings - Fork 5
fix: lazy-load optional ai peer #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shashi-stackone
merged 5 commits into
StackOneHQ:main
from
bozicovichsantiago20-oss:fix-optional-ai-peer-import
Jul 7, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d9a4de9
fix: lazy-load optional ai peer
bozicovichsantiago20-oss 3551e2e
test: cover optional ai peer import regression
bozicovichsantiago20-oss 5aea548
Merge branch 'main' into fix-optional-ai-peer-import
shashi-stackone 088252d
style(test): format tool-optional-ai.test.ts with oxfmt
shashi-stackone 17315ea
test: cover CJS output in optional ai peer regression test
shashi-stackone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| import { existsSync } from 'node:fs'; | ||
| import { readFile } from 'node:fs/promises'; | ||
| import { StackOneError } from './utils/error-stackone'; | ||
| import { peerDependencies } from '../package.json'; | ||
| import { ParameterLocation, type ExecuteConfig, type ToolParameters } from './types'; | ||
|
|
||
| const builtToolEsm = new URL('../dist/src/tool.mjs', import.meta.url); | ||
| const builtToolCjs = new URL('../dist/src/tool.cjs', import.meta.url); | ||
| const distReady = existsSync(builtToolEsm) && existsSync(builtToolCjs); | ||
|
|
||
| const createExecuteConfig = (): ExecuteConfig => ({ | ||
| kind: 'http', | ||
| method: 'GET', | ||
| url: 'https://api.example.com/test/{id}', | ||
| bodyType: 'json', | ||
| params: [ | ||
| { | ||
| name: 'id', | ||
| location: ParameterLocation.PATH, | ||
| type: 'string', | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| const createParameters = (): ToolParameters => ({ | ||
| type: 'object', | ||
| properties: { id: { type: 'string', description: 'ID parameter' } }, | ||
| }); | ||
|
|
||
| describe('BaseTool optional ai peer handling', () => { | ||
| afterEach(() => { | ||
| vi.resetModules(); | ||
| vi.restoreAllMocks(); | ||
| }); | ||
|
|
||
| it('rejects toClaudeAgentSdkTool with StackOneError and install hint when ai is unavailable', async () => { | ||
| vi.doMock('./utils/try-import', () => ({ | ||
| tryImport: vi.fn(async (moduleName: string, installHint: string) => { | ||
| if (moduleName === 'ai') { | ||
| throw new StackOneError( | ||
| `${moduleName} is not installed. Please install it with: ${installHint}`, | ||
| ); | ||
| } | ||
|
|
||
| throw new Error(`Unexpected module request: ${moduleName}`); | ||
| }), | ||
| })); | ||
|
|
||
| const { BaseTool } = await import('./tool'); | ||
| const tool = new BaseTool('test_tool', 'Test tool', createParameters(), createExecuteConfig()); | ||
|
|
||
| await expect(tool.toClaudeAgentSdkTool()).rejects.toBeInstanceOf(StackOneError); | ||
| await expect(tool.toClaudeAgentSdkTool()).rejects.toThrow( | ||
| `ai is not installed. Please install it with: npm install ai (requires ${peerDependencies.ai})`, | ||
| ); | ||
| }); | ||
|
|
||
| it.skipIf(!distReady)('keeps the built ESM module free of a top-level ai import', async () => { | ||
| const builtToolModule = await readFile(builtToolEsm, 'utf8'); | ||
|
|
||
| expect(builtToolModule).toContain('tryImport("ai"'); | ||
| expect(builtToolModule).not.toMatch(/^\s*import\s+.*['"]ai['"]/m); | ||
| }); | ||
|
|
||
| it.skipIf(!distReady)('keeps the built CJS module free of a top-level ai require', async () => { | ||
| const builtToolModule = await readFile(builtToolCjs, 'utf8'); | ||
|
|
||
| expect(builtToolModule).toContain('tryImport("ai"'); | ||
| expect(builtToolModule).not.toMatch(/require\(["']ai["']\)/); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.