feat: wire --rubrics flag to RubricConfig.load_bundle() - #178
Draft
luca-belli wants to merge 1 commit into
Draft
Conversation
luca-belli
marked this pull request as draft
July 23, 2026 00:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RubricConfig.load_bundle()); base branch is that PR's branch, notmainjudge.py's--rubrics/-rflag was declared but never read;main()now loadsargs.rubrics[0]viaRubricConfig.load_bundle()instead of hardcodingRubricConfig.load(rubric_folder="data")data/rubric.tsvtodata/rubric_manifest.json(the production manifest added in feat: add RubricConfig.load_bundle() for rubric bundle manifests #177)--rubricsvalue now prints a warning to stderr and uses only the first (multi-rubric support isn't implemented yet; kept the flag's list shape forward-compatible)run_pipeline.pyhas its own--rubricsflag that it forwards straight intojudge.py'smain()-- updated its default the same way so the full pipeline doesn't break on its own defaulttests/fixtures/rubric_manifest_multi_row.json, a second test bundle with genuinely different rubric content, used by a new end-to-end test proving--rubricsactually drives which bundle loads (not a hardcoded no-op)Test plan
uv run pytest -m "not live"passes (965 passed)--rubrics <manifest>loads distinct rubric content for two different manifests (realRubricConfig.load_bundle(), no mocking of that call)--rubricsvalues warns on stderr and uses only the firstdata/rubric.tsvdefault or mockedRubricConfig.loaduv run ruff check/uv run ruff format --checkclean