Make version mismatch warning informative and actionable#4505
Merged
alejoe91 merged 4 commits intoSpikeInterface:mainfrom Apr 17, 2026
Merged
Make version mismatch warning informative and actionable#4505alejoe91 merged 4 commits intoSpikeInterface:mainfrom
alejoe91 merged 4 commits intoSpikeInterface:mainfrom
Conversation
The old warning told users to downgrade, which is unhelpful when they upgraded intentionally. The new message states both the saved and current versions and tells the user to re-save the object to update it. Closes SpikeInterface#4495
The old warning told users to downgrade, which is unhelpful when they upgraded intentionally. The new message states both versions, notes that there may be minor differences in defaults or behavior, and tells the user to re-save the object to remove the warning. Closes SpikeInterface#4495
h-mayorquin
commented
Apr 16, 2026
Collaborator
Author
h-mayorquin
left a comment
h-mayorquin
left a comment
There was a problem hiding this comment.
After the meeting on 2026-04-16 we decided to remove this as this is too general and the recording and sorting have been more or less table. We should have more specific warnings on the analyzer
Collaborator
Author
Done. |
alejoe91
approved these changes
Apr 16, 2026
Member
|
Ah! The peace and quiet of no unnecessary warnings 
|
chrishalcrow
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version mismatch warning in
_load_extractor_from_dicttold users to downgrade, which is unhelpful when they upgraded on purpose. If the object loads successfully it is probably fine, so the warning should convey two things: that there may be minor differences in default parameters or behavior across versions, and that re-saving the object (viasave(),save_to_folder(), orsave_to_zarr()) stamps the current version and removes the warning. Known backward-compatibility issues continue to be handled silently by_handle_backward_compatibility.Closes #4495