Open
Conversation
alejoe91
added
core
| return i0, i1 | ||
|
|
||
| def compute(self, traces, start_frame, end_frame, segment_index, max_margin, peak_slice): | ||
| def compute(self, chunk, start_frame, end_frame, segment_index, max_margin, peak_slice): |
Member
There was a problem hiding this comment.
I think in the context of spikeinterface we can keep "traces" no ?
the code will be more redable and and this do not change the signature
| need_first_call_before_pipeline = False | ||
|
|
||
| def get_trace_margin(self): | ||
| def get_data_margin(self): |
| start_frame=start_frame, | ||
| end_frame=end_frame, | ||
| channel_indices=slice(None), | ||
| last_dimension_indices=slice(None), |
Member
There was a problem hiding this comment.
??
why this renaming.
We need to handle the backward compatibility.
Comment on lines
+62
to
+63
| def compute(self, chunk, start_frame, end_frame, segment_index, max_margin): | ||
| traces = chunk |
Member
There was a problem hiding this comment.
For internal si function we can kepp this no ?
Suggested change
| def compute(self, chunk, start_frame, end_frame, segment_index, max_margin): | |
| traces = chunk | |
| def compute(self, traces, start_frame, end_frame, segment_index, max_margin): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilding #4216 on top of #4462
This PR introduces a
ChunkableMixinclass (for extractors) and aChunkableSegment. These can be used as base classes for any class that can be chunked in the first dimension (e.g.,BaseRecording-BaseImaging).This is done by "abstracting" the
get_tracesinto a more generalget_data, and implementing other key methods as:get_sample_size_in_bytesget_memory_sizeget_shapeThe
ChunkableSegmentis also in charge of all the low level time handling.This large refactor allows to centralize the following "machinery" (in
chunkable_toolsandjob_tools)write_binary/write_memory/add_to_zarrChunkExecutor(previousChunkRecordingExecutor)run_node_pipelineNOTE: Created as draft to show diff before #4462 is merged