Block merging playing cards with non-playing cards#856
Open
paulkent-coder wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a check to can_merge_ds to ensure playing cards cannot be double-sided-merged with non-playing cards, even if they are both in the same card area (e.g. playing card moved to the joker tray with Quantify).
This change entails a bit of a philosophical statement, but I think it's one the Spectralpack team will find sympathetic. From my interactions with members of the dev team on Discord, the double-sided edition is notorious for being an albatross around Cryptid's neck – a massive hassle to code and maintain and extremely liable to glitchy behavior. This particular situation of merging playing cards with non-playing cards represents an entire surface of extremely rare and thorny edge cases that I estimate to be way too much effort to be worth supporting.
For example: multiuse CCDs put in the joker tray with Quantify are returned to your hand upon use. If the CCD in question is double-sided, and was merged with a joker during its visit to the joker tray, flipping the playing card to its joker side results in you having a joker in your hand. This is all the natural consequence of the current mechanics, but the end result is riddled with unanswered design questions. What does it even mean to have a joker in your hand? How is such a thing supposed to behave? What happens if you play it? Under what circumstances should its ability activate?
I suspect the Spectralpack team has no interest in going through the trouble of answering questions like these, especially considering their efforts are currently focused on Cryptid 2. That being the case, I think this whole branch of the state space is best amputated at the source; but I leave it to your judgment to decide.