Fix rendering on macOS#205
Open
andreypfau wants to merge 2 commits into
Open
Conversation
- grass and bird positions computed in the vertex shader, compute passes dropped - indirect light renderer gated on GL 4.3 instead of 4.0 - int attributes in float vertex formats written and read as floats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three bugs blocked rendering on macOS. None are Apple-specific — NVIDIA drivers just tolerated them.
#version 410 core. Bird flocking is replaced with per-bird orbits fitted to the boids simulation (flock radius 2.89 → 3.17, nearest neighbour 0.56 → 0.54).IndirectLightRenderer.isSupported()checks for GL 4.0, but the renderer draws withglMultiDrawElementsIndirect, which is 4.3. On Apple's 4.1 the check passes and the missing entry point aborts the JVM under any point light. Now gated on the capability actually used, so Veil falls back to the instanced renderer.EnableHeight,ResolutionandMaterialare declared FLOAT in the vertex format, written withputIntand read asin int. Carpet and ceiling tile took the wrong branch and rendered broken. Made float end to end. (Same issue Textures completely bugged #184)Tested on macOS 26.3, Apple Silicon.